Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

Add tox.ini for tox (http://tox.testrun.org/) #38

Merged
merged 4 commits into from
Apr 14, 2014

Conversation

msabramo
Copy link
Contributor

This adds support for testing with tox.

Sample run:

marca@marca-mac:~/dev/git-repos/terrarium$ tox
...
  py25: commands succeeded
  py26: commands succeeded
  py27: commands succeeded
ERROR:   pypy: commands failed

Note: I know that you have Travis CI set up which I also love. I think it's handy to have both Travis CI and tox set up -- the reason is that tox lets developers test their changes locally across multiple Pythons without having to check in or push their changes. Thus, I find Tox super handy for working on Python 3 compatibility, because you can keep iterating on making changes and testing with Tox.

As for the pypy failure, there only seems to be one test failure, so I thought it might be easy to fix. I filed it as issue #39.

Note that you can run a single test more quickly like this:

tox -e pypy -- tests.tests:TestTerrarium.test_install_storage_dir_archive_extracted

@msabramo
Copy link
Contributor Author

msabramo commented Feb 4, 2014

Any interest in this?

@winhamwr
Copy link
Contributor

winhamwr commented Feb 4, 2014

Hi Marc,

Thanks for the reminder, and sorry about the lack of response. I'm not speaking for @kylegibson, but from my perspective, I'm +1 on having a working tox setup.

One concern I have is the duplication between the tox.ini and the .travis.yml files. Ideally, it would be closer to the way https://github.com/PolicyStat/jobtastic handles things, with the .travis.yml calling tox. Does that make sense?

-Wes

@kylegibson
Copy link
Member

Thanks for this pull request!

kylegibson added a commit that referenced this pull request Apr 14, 2014
@kylegibson kylegibson merged commit 70413dd into PolicyStat:master Apr 14, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants