-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add collapsibility to calculator pages #1878
Merged
nikhilwoodruff
merged 28 commits into
PolicyEngine:master
from
anth-volk:feat/1721-collapsible-calc
Jun 17, 2024
Merged
Add collapsibility to calculator pages #1878
nikhilwoodruff
merged 28 commits into
PolicyEngine:master
from
anth-volk:feat/1721-collapsible-calc
Jun 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeeCoder/use-resize-observer#40 Jest... 👎 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1878 +/- ##
==========================================
- Coverage 31.19% 30.92% -0.27%
==========================================
Files 172 174 +2
Lines 6476 6561 +85
Branches 2039 2065 +26
==========================================
+ Hits 2020 2029 +9
- Misses 4343 4419 +76
Partials 113 113 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1721
Fixes #1862
Changes
This adds collapsibility to the calculator pages within both the household and policy calculators. It also adds automatic resizing to the charts featured within the various parts of the calculator (via
useContext
), alters the bottom bar on the policy calculator to better fit the new design and size, and fixes the baseline input bar so that it doesn't incorrectly shrink.Screenshots
AwesomeScreenshot-6_13_2024.10.50.01PM.mp4
Tests
None have been added.