Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add collapsibility to calculator pages #1878

Merged

Conversation

anth-volk
Copy link
Collaborator

Description

Fixes #1721
Fixes #1862

Changes

This adds collapsibility to the calculator pages within both the household and policy calculators. It also adds automatic resizing to the charts featured within the various parts of the calculator (via useContext), alters the bottom bar on the policy calculator to better fit the new design and size, and fixes the baseline input bar so that it doesn't incorrectly shrink.

Screenshots

AwesomeScreenshot-6_13_2024.10.50.01PM.mp4

Tests

None have been added.

@anth-volk anth-volk requested a review from nikhilwoodruff June 13, 2024 20:54
@anth-volk
Copy link
Collaborator Author

ZeeCoder/use-resize-observer#40 Jest... 👎

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 8.49057% with 97 lines in your changes missing coverage. Please review.

Project coverage is 30.92%. Comparing base (cea1021) to head (8c3236e).
Report is 8 commits behind head on master.

Files Patch % Lines
src/layout/ThreeColumnPage.jsx 0.00% 36 Missing ⚠️
src/layout/BottomCarousel.jsx 0.00% 12 Missing ⚠️
src/pages/policy/input/ParameterEditor.jsx 0.00% 12 Missing ⚠️
src/controls/CollapseButton.jsx 0.00% 10 Missing ⚠️
src/layout/HoverCard.jsx 64.28% 5 Missing ⚠️
src/layout/CollapsedPanel.jsx 0.00% 3 Missing ⚠️
src/pages/HouseholdPage.jsx 0.00% 3 Missing ⚠️
src/pages/PolicyPage.jsx 0.00% 3 Missing ⚠️
src/pages/policy/input/ParameterOverTime.jsx 0.00% 1 Missing ⚠️
src/pages/policy/output/CliffImpact.jsx 0.00% 1 Missing ⚠️
... and 11 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1878      +/-   ##
==========================================
- Coverage   31.19%   30.92%   -0.27%     
==========================================
  Files         172      174       +2     
  Lines        6476     6561      +85     
  Branches     2039     2065      +26     
==========================================
+ Hits         2020     2029       +9     
- Misses       4343     4419      +76     
  Partials      113      113              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nikhilwoodruff nikhilwoodruff merged commit 90f8a62 into PolicyEngine:master Jun 17, 2024
2 of 4 checks passed
@anth-volk anth-volk deleted the feat/1721-collapsible-calc branch June 17, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
2 participants