Skip to content
This repository has been archived by the owner on Dec 11, 2022. It is now read-only.

Use RasterDataSources as the reference for raster data #86

Closed
wants to merge 41 commits into from

Conversation

tpoisot
Copy link
Member

@tpoisot tpoisot commented Mar 4, 2021

This is a massive (read: breaking) PR which uses RasterDataSources.jl as the source for data. It is only breaking in that the worldclim, etc, methods are deprecated, and replaced by a call of the form

SimpleSDMPredictor(CHELSA{BioClim}, FutureClimate{CCSM4,RCP45}, [1,12], left=10.0, right=25.0)

to get bc1 and bc12 from CHELSA under the specified climate change model with a specified bounding box.

Notably, because RasterDataSources.jl requires Julia 1.5, older versions are no longer supported.

Doc: https://ecojulia.github.io/SimpleSDMLayers.jl/previews/PR86/

@tpoisot
Copy link
Member Author

tpoisot commented Mar 4, 2021

This was easier that I thought. I'll update the doc, and then tag a release with the new version - or I might wait until EcoJulia/RasterDataSources.jl#24 is merged and released. Not sure yet.

@codecov-io
Copy link

codecov-io commented Mar 8, 2021

Codecov Report

Merging #86 (c0fed3a) into master (d7f4c58) will decrease coverage by 0.67%.
The diff coverage is 96.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
- Coverage   85.54%   84.86%   -0.68%     
==========================================
  Files          22       17       -5     
  Lines         512      456      -56     
==========================================
- Hits          438      387      -51     
+ Misses         74       69       -5     
Flag Coverage Δ
unittests 84.86% <96.15%> (-0.68%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/SimpleSDMLayers.jl 75.00% <ø> (-8.34%) ⬇️
src/io/ascii.jl 92.10% <ø> (ø)
src/io/geotiff.jl 100.00% <ø> (ø)
src/lib/overloads.jl 87.61% <ø> (ø)
src/operations/rescale.jl 50.00% <50.00%> (ø)
src/integrations/RasterDataSources.jl 100.00% <100.00%> (ø)
src/lib/types.jl 100.00% <100.00%> (ø)
src/operations/mosaic.jl 100.00% <100.00%> (ø)
src/recipes/recipes.jl 93.10% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7f4c58...c0fed3a. Read the comment docs.

@tpoisot
Copy link
Member Author

tpoisot commented Mar 24, 2021

Closing this one for now - development on RasterDataSources is kinda stalled.

@tpoisot tpoisot closed this Mar 24, 2021
@tpoisot tpoisot deleted the tp/RasterDataSources branch October 15, 2021 15:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants