Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a function to get the nearest names #42

Merged
merged 11 commits into from
Aug 1, 2021
Merged

Add a function to get the nearest names #42

merged 11 commits into from
Aug 1, 2021

Conversation

tpoisot
Copy link
Member

@tpoisot tpoisot commented Jul 22, 2021

What the pull request does

Based on a string, returns the names with the highest fuzzy matches, alongside their scores

👁️ doc

Type of change
Please indicate the relevant option(s)

  • ❇️ New feature (non-breaking change which adds functionality)
  • 📖 This change requires a documentation update

Checklist

  • The changes are documented
    • The docstrings of the different functions describe the arguments, purpose, and behavior
    • There are examples in the documentation website
  • The changes are tested
  • The changes do not modify the behavior of the previously existing functions
    • If they do, please explain why and how in the introduction paragraph
  • For new contributors - my name and information are added to .zenodo.json
  • The Project.toml field version has been updated
    • Change the last number for a v0.0.x series release, a bug fix, or a performance improvement
    • Change the middle number for additional features that do not break the current test suite (unless you fix a bug in the test suite)
    • Change the first number for changes that break the current test suite

@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2021

Codecov Report

Merging #42 (b7eac22) into main (4e50021) will increase coverage by 3.25%.
The diff coverage is 73.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
+ Coverage   66.17%   69.42%   +3.25%     
==========================================
  Files          10       11       +1     
  Lines         136      157      +21     
==========================================
+ Hits           90      109      +19     
- Misses         46       48       +2     
Flag Coverage Δ
unittests 69.42% <73.07%> (+3.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/NCBITaxonomy.jl 100.00% <ø> (ø)
src/exceptions.jl 14.28% <0.00%> (-1.51%) ⬇️
src/utility/similarnames.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e50021...b7eac22. Read the comment docs.

@tpoisot tpoisot marked this pull request as ready for review July 30, 2021 21:01
@tpoisot tpoisot merged commit 613a333 into main Aug 1, 2021
@tpoisot tpoisot deleted the tpoisot/issue20 branch August 1, 2021 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants