Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a freshness parameter #24

Merged
merged 4 commits into from
Dec 8, 2020
Merged

Add a freshness parameter #24

merged 4 commits into from
Dec 8, 2020

Conversation

tpoisot
Copy link
Member

@tpoisot tpoisot commented Dec 8, 2020

What the pull request does
Fixes #23 by warning users if the taxonomy is over 30 days old (give or take a few hours).

Type of change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ❇️ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📖 This change requires a documentation update

Checklist

  • The changes are documented
    • The docstrings of the different functions describe the arguments, purpose, and behavior
    • There are examples in the documentation website
  • The changes are tested
  • The changes do not modify the behavior of the previously existing functions
    • If they do, please explain why and how in the introduction paragraph
  • The Project.toml field version has been updated

@codecov-io
Copy link

codecov-io commented Dec 8, 2020

Codecov Report

Merging #24 (a525299) into main (eabb3d1) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #24   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines           75        77    +2     
=========================================
+ Hits            75        77    +2     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/NCBITaxonomy.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eabb3d1...a525299. Read the comment docs.

@tpoisot tpoisot merged commit d8ed6dc into main Dec 8, 2020
@tpoisot tpoisot deleted the tpoisot/issue23 branch March 22, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a freshness parameter
2 participants