Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In-part names only return the first element #39

Closed
tpoisot opened this issue Jul 14, 2021 · 2 comments · Fixed by #40
Closed

In-part names only return the first element #39

tpoisot opened this issue Jul 14, 2021 · 2 comments · Fixed by #40
Assignees
@tpoisot
Labels
bug Something isn't working need-triage

Comments

@tpoisot
Copy link
Member

tpoisot commented Jul 14, 2021

Describe the bug

julia> ncbi"Reptilia"
Testudines (ncbi:8459)

Expected behavior

An array of names? A warning? Both?
@tpoisot tpoisot added bug Something isn't working need-triage labels Jul 14, 2021
@tpoisot tpoisot self-assigned this Jul 14, 2021
@tpoisot
Copy link
Member Author

tpoisot commented Jul 15, 2021

Current solution is to throw a specific error, and indicate which taxa can be used instead. This is going to interrupt some workflows but this is what we have try/catch.

@tpoisot
Copy link
Member Author

tpoisot commented Jul 15, 2021

This might require replacing the return nothing when no name is found by a specific NCBITaxaNotFound error...?

tpoisot added a commit that referenced this issue Jul 15, 2021
@tpoisot
stat working on #39
93476a1
@tpoisot tpoisot mentioned this issue Jul 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tpoisot tpoisot

Labels
bug Something isn't working need-triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

In-part / non-unique names PoisotLab/NCBITaxonomy.jl
1 participant
@tpoisot