Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set compile features on imported PCL targets #3567

Merged
merged 2 commits into from
Jan 18, 2020
Merged

Set compile features on imported PCL targets #3567

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aef809c
Set compile features on imported PCL targets
taketwo Jan 17, 2020
191a9f6
Remove trailing spaces and ^M
taketwo Jan 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions PCLConfig.cmake.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -616,10 +616,10 @@ foreach(component ${PCL_TO_FIND_COMPONENTS})
IMPORTED_IMPLIB "${PCL_${COMPONENT}_LIBRARY}"
)
endif()
else() # header-only
add_library(${pcl_component} INTERFACE IMPORTED)
else() # header-only
add_library(${pcl_component} INTERFACE IMPORTED)
endif()

foreach(def ${PCL_DEFINITIONS})
string(REPLACE " " ";" def2 ${def})
string(REGEX REPLACE "^-D" "" def3 "${def2}")
Expand Down Expand Up @@ -648,6 +648,7 @@ foreach(component ${PCL_TO_FIND_COMPONENTS})
PROPERTIES
INTERFACE_COMPILE_DEFINITIONS "${definitions}"
INTERFACE_COMPILE_OPTIONS "$<$<COMPILE_LANGUAGE:CXX>:${PCL_COMPILE_OPTIONS}>"
INTERFACE_COMPILE_FEATURES "@PCL_CXX_COMPILE_FEATURES@"
INTERFACE_INCLUDE_DIRECTORIES "${PCL_${COMPONENT}_INCLUDE_DIRS};${PCL_CONF_INCLUDE_DIR}"
)
# If possible, we use target_link_libraries to avoid problems with link-type keywords,
Expand Down