Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCL_COMMON: removing default destructors - part 2 #3454

Merged
merged 2 commits into from
Nov 8, 2019
+1 −25
Merged

PCL_COMMON: removing default destructors - part 2 #3454

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97e7dcf
PCL_COMMON: removing default destructors - part 2
Nov 6, 2019
aaef570
first turn of review of pull request
Nov 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions common/include/pcl/common/time.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,6 @@ namespace pcl
{
}

/** \brief Destructor. */
virtual ~StopWatch () = default;
//TODO: check if copy/move construcors/assignment operators are needed

/** \brief Retrieve the time in milliseconds spent since the last call to \a reset(). */
Expand Down
2 changes: 0 additions & 2 deletions common/include/pcl/common/transformation_from_correspondences.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,6 @@ namespace pcl
TransformationFromCorrespondences ()
{ reset (); }

/** Destructor */
~TransformationFromCorrespondences () = default;
//TODO: check if copy/move constructors/assignment operators are needed

//-----METHODS-----
Expand Down
2 changes: 0 additions & 2 deletions common/include/pcl/common/vector_average.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,6 @@ namespace pcl
//-----CONSTRUCTOR&DESTRUCTOR-----
/** Constructor - dimension gives the size of the vectors to work with. */
VectorAverage ();
/** Destructor */
~VectorAverage () = default;
//TODO: check if copy/move constructors/assignment operators are needed

//-----METHODS-----
Expand Down
6 changes: 0 additions & 6 deletions common/include/pcl/correspondence.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,6 @@ namespace pcl
index_query (_index_query), index_match (_index_match), distance (_distance)
{}

/** \brief Empty destructor. */
virtual ~Correspondence () = default;
//TODO: check if copy/move constructors/assignment operators are needed

PCL_MAKE_ALIGNED_OPERATOR_NEW
Expand Down Expand Up @@ -122,8 +120,6 @@ namespace pcl
Eigen::Vector3f point1; //!< The 3D position of the point in the first coordinate frame
Eigen::Vector3f point2; //!< The 3D position of the point in the second coordinate frame

/** \brief Empty destructor. */
virtual ~PointCorrespondence3D () = default;
//TODO: check if copy/move constructors/assignment operators are needed

PCL_MAKE_ALIGNED_OPERATOR_NEW
Expand All @@ -139,8 +135,6 @@ namespace pcl
{
Eigen::Affine3f transformation; //!< The transformation to go from the coordinate system
//!< of point2 to the coordinate system of point1
/** \brief Empty destructor. */
virtual ~PointCorrespondence6D () = default;
//TODO: check if copy/move constructors/assignment operators are needed

PCL_MAKE_ALIGNED_OPERATOR_NEW
Expand Down
2 changes: 0 additions & 2 deletions common/include/pcl/point_cloud.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,8 +208,6 @@ namespace pcl
, height (height_)
{}

/** \brief Destructor. */
virtual ~PointCloud () = default;
//TODO: check if copy/move contructors/assignment operators are needed

/** \brief Add a point cloud to the current cloud.
Expand Down