Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer C++ method std::acos over C method acos #3236

Merged
merged 1 commit into from
Jul 19, 2019
Merged

Prefer C++ method std::acos over C method acos #3236

merged 1 commit into from
Jul 19, 2019

Conversation

SunBlack
Copy link
Contributor

@SunBlack SunBlack commented Jul 16, 2019 •
edited
Loading

This fix Clang-tidy warning call to 'acos' promotes float to double in

pcl/features/src/pfh.cpp

Line 67 in 8163917

if (acos (std::fabs (angle1)) > acos (std::fabs (angle2)))

This issues seem to be missed in #3087.

@taketwo taketwo merged commit c0051c0 into PointCloudLibrary:master Jul 19, 2019
@SunBlack SunBlack deleted the use_std-acos branch July 19, 2019 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taketwo taketwo taketwo approved these changes

@SergioRAgostinho SergioRAgostinho SergioRAgostinho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SunBlack @taketwo @SergioRAgostinho