-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dead links in Walkthrough tutorial #2532
Conversation
Since we can only provide an up-to-date version of this tutorial I would remove the range image module. The location paths and what-not are also a little bit redundant to have them generated for every single module. Plus, the path prefix mentions Edit: So apparently it was not removed but moved to common. Don't remove it but put a note that it is not longer a module and it was merged to common. |
Sorry for the extra hassle. When I mentioned to replace the path prefixes my idea was to have CMake automatically filling in that version prefix. Otherwise we will "need" to constantly update those paths with every minor version. |
IMHO that would be too much of a trouble, the usefulness of these paths is questionable anyway. What I can do is replace |
On 09/10/2018 13:21, Sergey Alexandrov wrote:
IMHO that would be too much of a trouble, the usefulness of these
paths is questionable anyway. What I can do is replace |1.6| with
|$(PCL_VERSION)|.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2532 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABoUVvOue-mQ7z18JP-AtIH3rsVu9Rnxks5ujIbJgaJpZM4XLwYm>.
|PCL_VERSION| also includes the patch version, which is not added to the
install prefix.
New proposal: erase all the paths.
|
|
Sounds good. Go with that. |
Also replace explicit version with pseudo-variable $(PCL_VERSION).
@@ -168,7 +168,7 @@ Keypoints | |||
|
|||
| | |||
|
|||
**Documentation:** http://docs.pointclouds.org/trunk/a02949.html | |||
**Documentation:** http://docs.pointclouds.org/trunk/group__keypoints.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dead link!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please create a PR :)
Fixes #2517.
Not sure what to do about "Range Image library". We don't have such library anymore 😅