Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dead links in Walkthrough tutorial #2532

Merged
merged 1 commit into from
Oct 11, 2018

Conversation

taketwo
Copy link
Member

@taketwo taketwo commented Oct 7, 2018

Fixes #2517.

Not sure what to do about "Range Image library". We don't have such library anymore 😅

@SergioRAgostinho
Copy link
Member

SergioRAgostinho commented Oct 8, 2018

Since we can only provide an up-to-date version of this tutorial I would remove the range image module. The location paths and what-not are also a little bit redundant to have them generated for every single module. Plus, the path prefix mentions pcl-1.6. It should be updated to the current version 1.8(.1).

Edit: So apparently it was not removed but moved to common. Don't remove it but put a note that it is not longer a module and it was merged to common.

@SergioRAgostinho
Copy link
Member

Sorry for the extra hassle. When I mentioned to replace the path prefixes my idea was to have CMake automatically filling in that version prefix. Otherwise we will "need" to constantly update those paths with every minor version.

@taketwo
Copy link
Member Author

taketwo commented Oct 9, 2018

IMHO that would be too much of a trouble, the usefulness of these paths is questionable anyway. What I can do is replace 1.6 with $(PCL_VERSION).

@SergioRAgostinho
Copy link
Member

SergioRAgostinho commented Oct 9, 2018 via email

@taketwo
Copy link
Member Author

taketwo commented Oct 9, 2018

$(PCL_VERSION) is not really a variable or anything, just a "symbol" that can have any meaning. In this case it will mean "major.minor".

@SergioRAgostinho
Copy link
Member

Sounds good. Go with that.

Also replace explicit version with pseudo-variable $(PCL_VERSION).
@SergioRAgostinho SergioRAgostinho merged commit 4f90f39 into PointCloudLibrary:master Oct 11, 2018
@taketwo taketwo deleted the fix-2517 branch October 11, 2018 13:39
@@ -168,7 +168,7 @@ Keypoints

|

**Documentation:** http://docs.pointclouds.org/trunk/a02949.html
**Documentation:** http://docs.pointclouds.org/trunk/group__keypoints.html

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead link!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants