Skip to content

Commit

Permalink
Fixed formatting issues flagged by CI [PCL-2731]
Browse files Browse the repository at this point in the history
Signed-off-by: Norm Evangelista <norm.evangelista@gmail.com>
  • Loading branch information
gnawme committed Mar 6, 2021
1 parent 5cfc686 commit 5203f5d
Show file tree
Hide file tree
Showing 23 changed files with 33 additions and 39 deletions.
2 changes: 1 addition & 1 deletion ml/include/pcl/ml/feature_handler.h
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ template <class FeatureType, class DataSet, class ExampleIndex>
class PCL_EXPORTS FeatureHandler {
public:
/** Destructor. */
virtual ~FeatureHandler()= default;;
virtual ~FeatureHandler() = default;

/** Creates random features.
*
Expand Down
3 changes: 1 addition & 2 deletions ml/include/pcl/ml/impl/dt/decision_forest_evaluator.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,7 @@ template <class FeatureType,
class ExampleIndex,
class NodeType>
pcl::DecisionForestEvaluator<FeatureType, DataSet, LabelType, ExampleIndex, NodeType>::
~DecisionForestEvaluator()
= default;
~DecisionForestEvaluator() = default;

template <class FeatureType,
class DataSet,
Expand Down
3 changes: 1 addition & 2 deletions ml/include/pcl/ml/impl/dt/decision_forest_trainer.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,7 @@ template <class FeatureType,
class ExampleIndex,
class NodeType>
DecisionForestTrainer<FeatureType, DataSet, LabelType, ExampleIndex, NodeType>::
~DecisionForestTrainer()
= default;
~DecisionForestTrainer() = default;

template <class FeatureType,
class DataSet,
Expand Down
6 changes: 2 additions & 4 deletions ml/include/pcl/ml/impl/dt/decision_tree_evaluator.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -52,17 +52,15 @@ template <class FeatureType,
class ExampleIndex,
class NodeType>
DecisionTreeEvaluator<FeatureType, DataSet, LabelType, ExampleIndex, NodeType>::
DecisionTreeEvaluator()
= default;
DecisionTreeEvaluator() = default;

template <class FeatureType,
class DataSet,
class LabelType,
class ExampleIndex,
class NodeType>
DecisionTreeEvaluator<FeatureType, DataSet, LabelType, ExampleIndex, NodeType>::
~DecisionTreeEvaluator()
= default;
~DecisionTreeEvaluator() = default;

template <class FeatureType,
class DataSet,
Expand Down
3 changes: 1 addition & 2 deletions ml/include/pcl/ml/impl/dt/decision_tree_trainer.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,7 @@ template <class FeatureType,
class ExampleIndex,
class NodeType>
DecisionTreeTrainer<FeatureType, DataSet, LabelType, ExampleIndex, NodeType>::
~DecisionTreeTrainer()
= default;
~DecisionTreeTrainer() = default;

template <class FeatureType,
class DataSet,
Expand Down
2 changes: 1 addition & 1 deletion ml/include/pcl/ml/pairwise_potential.h
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ class PairwisePotential {
const float w);

/** Deconstructor for PairwisePotential class. */
~PairwisePotential()= default;;
~PairwisePotential() = default;

void
compute(std::vector<float>& out,
Expand Down
2 changes: 1 addition & 1 deletion ml/include/pcl/ml/stats_estimator.h
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ class PCL_EXPORTS StatsEstimator {

public:
/** Destructor. */
virtual ~StatsEstimator()= default;;
virtual ~StatsEstimator() = default;

/** Returns the number of brances a node can have (e.g. a binary tree has 2). */
virtual std::size_t
Expand Down
4 changes: 2 additions & 2 deletions ml/src/svm.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -520,9 +520,9 @@ Kernel::k_function(const svm_node* x, const svm_node* y, const svm_parameter& pa
class Solver {

public:
Solver()= default;;
Solver() = default;

virtual ~Solver()= default;;
virtual ~Solver() = default;

struct SolutionInfo {
double obj;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,8 @@ class TransformationEstimation {
public:
using Matrix4 = Eigen::Matrix<Scalar, 4, 4>;

TransformationEstimation()= default;;
virtual ~TransformationEstimation()= default;;
TransformationEstimation() = default;
virtual ~TransformationEstimation() = default;

/** \brief Estimate a rigid rotation transformation between a source and a target
* point cloud. \param[in] cloud_src the source point cloud dataset \param[in]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@ class TransformationEstimation2D
using Matrix4 =
typename TransformationEstimation<PointSource, PointTarget, Scalar>::Matrix4;

TransformationEstimation2D()= default;;
virtual ~TransformationEstimation2D()= default;;
TransformationEstimation2D() = default;
virtual ~TransformationEstimation2D() = default;

/** \brief Estimate a rigid transformation between a source and a target point cloud
* in 2D. \param[in] cloud_src the source point cloud dataset \param[in] cloud_tgt the
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,8 @@ class TransformationEstimationDualQuaternion
using Matrix4 =
typename TransformationEstimation<PointSource, PointTarget, Scalar>::Matrix4;

TransformationEstimationDualQuaternion()= default;;
~TransformationEstimationDualQuaternion()= default;;
TransformationEstimationDualQuaternion() = default;
~TransformationEstimationDualQuaternion() = default;

/** \brief Estimate a rigid rotation transformation between a source and a target
* point cloud using dual quaternion optimization \param[in] cloud_src the source
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ class TransformationEstimationLM
}

/** \brief Destructor. */
~TransformationEstimationLM() override= default;;
~TransformationEstimationLM() override = default;

/** \brief Estimate a rigid rotation transformation between a source and a target
* point cloud using LM. \param[in] cloud_src the source point cloud dataset
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,8 @@ class TransformationEstimationPointToPlane

using Vector4 = Eigen::Matrix<Scalar, 4, 1>;

TransformationEstimationPointToPlane()= default;;
~TransformationEstimationPointToPlane()= default;;
TransformationEstimationPointToPlane() = default;
~TransformationEstimationPointToPlane() = default;

protected:
Scalar
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,8 @@ class TransformationEstimationPointToPlaneLLS
using Matrix4 =
typename TransformationEstimation<PointSource, PointTarget, Scalar>::Matrix4;

TransformationEstimationPointToPlaneLLS()= default;;
~TransformationEstimationPointToPlaneLLS() override= default;;
TransformationEstimationPointToPlaneLLS() = default;
~TransformationEstimationPointToPlaneLLS() override = default;

/** \brief Estimate a rigid rotation transformation between a source and a target
* point cloud using SVD. \param[in] cloud_src the source point cloud dataset
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,8 @@ class TransformationEstimationPointToPlaneLLSWeighted
using Matrix4 =
typename TransformationEstimation<PointSource, PointTarget, Scalar>::Matrix4;

TransformationEstimationPointToPlaneLLSWeighted()= default;;
virtual ~TransformationEstimationPointToPlaneLLSWeighted()= default;;
TransformationEstimationPointToPlaneLLSWeighted() = default;
virtual ~TransformationEstimationPointToPlaneLLSWeighted() = default;

/** \brief Estimate a rigid rotation transformation between a source and a target
* point cloud using SVD. \param[in] cloud_src the source point cloud dataset
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ class TransformationEstimationPointToPlaneWeighted
}

/** \brief Destructor. */
virtual ~TransformationEstimationPointToPlaneWeighted()= default;;
virtual ~TransformationEstimationPointToPlaneWeighted() = default;

/** \brief Estimate a rigid rotation transformation between a source and a target
* point cloud using LM. \param[in] cloud_src the source point cloud dataset
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ class TransformationEstimationSVD
* \param[in] use_umeyama Toggles whether or not to use 3rd party software*/
TransformationEstimationSVD(bool use_umeyama = true) : use_umeyama_(use_umeyama) {}

~TransformationEstimationSVD() override= default;;
~TransformationEstimationSVD() override = default;

/** \brief Estimate a rigid rotation transformation between a source and a target
* point cloud using SVD. \param[in] cloud_src the source point cloud dataset
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ class TransformationEstimationSymmetricPointToPlaneLLS

TransformationEstimationSymmetricPointToPlaneLLS()
: enforce_same_direction_normals_(true){};
~TransformationEstimationSymmetricPointToPlaneLLS()= default;;
~TransformationEstimationSymmetricPointToPlaneLLS() = default;

/** \brief Estimate a rigid rotation transformation between a source and a target
* point cloud using SVD. \param[in] cloud_src the source point cloud dataset
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,8 @@ class TransformationValidation {
using PointCloudTargetPtr = typename PointCloudTarget::Ptr;
using PointCloudTargetConstPtr = typename PointCloudTarget::ConstPtr;

TransformationValidation()= default;;
virtual ~TransformationValidation()= default;;
TransformationValidation() = default;
virtual ~TransformationValidation() = default;

/** \brief Validate the given transformation with respect to the input cloud data, and
* return a score. Pure virtual.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ class TransformationValidationEuclidean {
, force_no_recompute_(false)
{}

virtual ~TransformationValidationEuclidean()= default;;
virtual ~TransformationValidationEuclidean() = default;

/** \brief Set the maximum allowable distance between a point and its correspondence
* in the target in order for a correspondence to be considered \a valid. Default:
Expand Down
2 changes: 1 addition & 1 deletion registration/include/pcl/registration/warp_point_rigid.h
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ class WarpPointRigid {
};

/** \brief Destructor. */
virtual ~WarpPointRigid()= default;;
virtual ~WarpPointRigid() = default;

/** \brief Set warp parameters. Pure virtual.
* \param[in] p warp parameters
Expand Down
3 changes: 1 addition & 2 deletions stereo/include/pcl/stereo/impl/disparity_map_converter.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,7 @@ pcl::DisparityMapConverter<PointT>::DisparityMapConverter()
{}

template <typename PointT>
pcl::DisparityMapConverter<PointT>::~DisparityMapConverter()
= default;
pcl::DisparityMapConverter<PointT>::~DisparityMapConverter() = default;

template <typename PointT>
inline void
Expand Down
4 changes: 2 additions & 2 deletions stereo/include/pcl/stereo/stereo_matching.h
Original file line number Diff line number Diff line change
Expand Up @@ -428,7 +428,7 @@ class PCL_EXPORTS GrayStereoMatching : public StereoMatching {
class PCL_EXPORTS BlockBasedStereoMatching : public GrayStereoMatching {
public:
BlockBasedStereoMatching();
~BlockBasedStereoMatching() override= default;;
~BlockBasedStereoMatching() override = default;

/** \brief setter for the radius of the squared window
* \param[in] radius radius of the squared window used to compute the block-based
Expand Down Expand Up @@ -465,7 +465,7 @@ class PCL_EXPORTS AdaptiveCostSOStereoMatching : public GrayStereoMatching {
public:
AdaptiveCostSOStereoMatching();

~AdaptiveCostSOStereoMatching() override= default;;
~AdaptiveCostSOStereoMatching() override = default;

/** \brief setter for the radius (half length) of the column used for cost aggregation
* \param[in] radius radius (half length) of the column used for cost aggregation; the
Expand Down

0 comments on commit 5203f5d

Please sign in to comment.