-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
websocket client adapter #152
Conversation
7f9f923
to
91bc70b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a first pass through just focusing on the csp
related code as I'm not familiar with how websockets work.
91bc70b
to
5ffab22
Compare
1883fa9
to
1566b5f
Compare
1566b5f
to
15cf01d
Compare
15cf01d
to
9aaa2ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm comfortable with the vcpkg
, cmake
, conda
, and setup.py
changes. The remaining will require other people to review
663151f
to
e59c5ff
Compare
6fb4924
to
e13f08c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot the NOTICE
also has to be regenerated
Signed-off-by: Rieger <wr10136@devqtccrt05.saccap.int>
@@ -18,6 +18,7 @@ dependencies: | |||
- isort | |||
- libarrow=15 | |||
- librdkafka | |||
- libboost-headers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wrieg123 alphabetize!
Added a Websocket Client Adapter (w/ and w/o TLS support).
Further, there is an output adapter for updating headers on reconnects.