-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SWP-2832] Auth Service Upgrade: 5.6+ Package #5
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of things spotted with @oaklees
Also in KinesisFormatterTest
We should also test that the record array matches the output from the formatter.
$this->assertArrayHasKey('Data', $output);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting there! Some updates needed though - config still contains params that we've moved to logging.php
, and tests are pretty thin on the ground and not really doing much. As we're moving to only supporting 6+ moving forward we need to move to monolog 2 - we should also as a result really be increasing this test coverage and testing against these major versions with both PHP versions. See notes below to the type of test we can do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome stuff - looking really good - just a couple of notes around some minor tweaks and other stylistic changes.
Also, some StyleCI formatting to be corrected too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff 🙌🏻
Fix ?
Link to ticket: https://podpoint.atlassian.net/browse/SWP-2832
What has been done