Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SWP-2832] Auth Service Upgrade: 5.6+ Package #5

Merged
merged 13 commits into from
Jun 4, 2021
Merged

Conversation

HasnatH
Copy link
Contributor

@HasnatH HasnatH commented May 6, 2021

Fix ?

Link to ticket: https://podpoint.atlassian.net/browse/SWP-2832

What has been done

  • update structure so it can be added as a logging channel
  • supports Laravel 5.6+

Copy link
Contributor

@willthorpe willthorpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of things spotted with @oaklees

Also in KinesisFormatterTest
We should also test that the record array matches the output from the formatter.
$this->assertArrayHasKey('Data', $output);

composer.json Outdated Show resolved Hide resolved
tests/unit/ServiceProviderTest.php Outdated Show resolved Hide resolved
Copy link

@oaklees oaklees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting there! Some updates needed though - config still contains params that we've moved to logging.php, and tests are pretty thin on the ground and not really doing much. As we're moving to only supporting 6+ moving forward we need to move to monolog 2 - we should also as a result really be increasing this test coverage and testing against these major versions with both PHP versions. See notes below to the type of test we can do.

.gitignore Show resolved Hide resolved
README.md Show resolved Hide resolved
composer.lock Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
tests/unit/ServiceProviderTest.php Outdated Show resolved Hide resolved
src/Providers/ServiceProvider.php Outdated Show resolved Hide resolved
Copy link

@oaklees oaklees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff - looking really good - just a couple of notes around some minor tweaks and other stylistic changes.

Also, some StyleCI formatting to be corrected too.

.styleci.yml Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/Monolog/KinesisHandler.php Outdated Show resolved Hide resolved
src/Monolog/KinesisHandler.php Outdated Show resolved Hide resolved
tests/Unit/KinesisClientTest.php Outdated Show resolved Hide resolved
tests/Unit/KinesisClientTest.php Show resolved Hide resolved
tests/Unit/KinesisClientTest.php Outdated Show resolved Hide resolved
Copy link

@oaklees oaklees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff 🙌🏻

@willthorpe willthorpe self-requested a review June 1, 2021 13:47
@willthorpe willthorpe dismissed their stale review June 1, 2021 13:47

Outdated

@willthorpe willthorpe merged commit d39986f into master Jun 4, 2021
@clemblanco clemblanco deleted the feature/SWP-2832 branch November 29, 2021 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants