Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tags: do not present edit tag screen when tapping an existing tag in Saves #993

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Tags: do not present edit tag screen when tapping an existing tag in Saves #993

merged 1 commit into from
Apr 11, 2024

Conversation

Gio2018
Copy link
Collaborator

@Gio2018 Gio2018 commented Apr 11, 2024

Summary

  • This PR fixes an issue that caused the edit tags sheet to be presented when tapping an existing tag from a cell.

References

  • (if not otherwise specified, the issue reference is contained in the branch name)

Implementation Details

  • Update SavedItemViewModel, remove tag sheet presentation code when tapping an existing tag.

Test Steps

  • Tap a tag, verify that the filter works and the edit tag sheet does not appear.

PR Checklist:

  • Added Unit / UI tests
  • Self Review (review, clean up, documentation, run tests)
  • Basic Self QA

@Gio2018 Gio2018 added bug Something isn't working tags labels Apr 11, 2024
@Gio2018 Gio2018 added this to the 8.7.0 milestone Apr 11, 2024
@Gio2018 Gio2018 self-assigned this Apr 11, 2024
@Gio2018 Gio2018 requested a review from bassrock as a code owner April 11, 2024 18:19
@pocket-ci
Copy link
Contributor

pocket-ci commented Apr 11, 2024 •
edited
Loading

Messages
📖 No SwiftLint violations! 🎉
📖 Project coverage: 36.87%
📖 Checking XCode Environment Variables
📖 Edited 1 files
📖 Created 0 files

PocketKit: Coverage: 61.93

File Coverage
SavedItemsListViewModel.swift 82.32% ✅

PocketKitTests: Coverage: 28.2

File Coverage
SavedItemsListViewModel.swift 49.71% ⚠️

Generated by 🚫 Danger Swift against d5178e5

@Gio2018 Gio2018 merged commit 705cab6 into develop Apr 11, 2024
8 checks passed
@Gio2018 Gio2018 deleted the fix/POCKET-9727-tag-filtering branch April 11, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bassrock bassrock bassrock approved these changes

Assignees

@Gio2018 Gio2018

Labels
bug Something isn't working tags
Projects
None yet
Milestone
8.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Gio2018 @pocket-ci @bassrock