Fix broken view hierarchy in Xcode

[Gio2018]

Summary

• Apparently, not declaring RootViewModel as a state object works but breaks the view hierarchy in Xcode..

References

• Links to docs, tickets, designs if available

Implementation Details

• Declared @StateObject private var rootViewModel = RootViewModel() in PocketApp, removed the init() and added the start() method to the init() method in RootViewModel. This should not make a difference since the passed objects and the sequence of calls is unchanged. We need to do additional considerations when we enable multi windows, but the model likely can stay the same.

Test Steps

• Build/run with Xcode, then make sure the view hierarchy appears
• Smoke test the app and make sure it works as expected

PR Checklist:

• Added Unit / UI tests
• Self Review (review, clean up, documentation, run tests)
• Basic Self QA

[pocket-ci]

	Messages
📖	No SwiftLint violations! 🎉
📖	Project coverage: 36.65%
📖	Checking XCode Environment Variables
📖	Edited 6 files
📖	Created 0 files

Pocket.app: Coverage: 100.0

File	Coverage
PocketApp.swift	100.0%	✅

PocketKit: Coverage: 62.02

File	Coverage
PocketAppDelegate.swift	64.81%	✅
RootViewModel.swift	73.6%	✅
Services.swift	96.43%	✅

SaveToPocketKit: Coverage: 26.61

File	Coverage
MainViewController.swift	0.0%	⚠️

SharedPocketKit: Coverage: 65.29

File	Coverage
SignOutOnFirstLaunch.swift	100.0%	✅

SaveToPocketKitTests: Coverage: 0.0

File	Coverage
MainViewController.swift	0.0%	⚠️

SharedPocketKitTests: Coverage: 24.27

File	Coverage
SignOutOnFirstLaunch.swift	100.0%	✅

PocketKitTests: Coverage: 28.43

File	Coverage
SignOutOnFirstLaunch.swift	100.0%	✅
Services.swift	95.41%	✅
PocketAppDelegate.swift	69.1%	✅
RootViewModel.swift	76.0%	✅

Generated by 🚫 Danger Swift against 7f63508

[sentry-io]

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

• ‼️ LegacyPasswordRetriever View Issue
• ‼️ App Hanging: App hanging for at least 2000 ms. AsyncOperation.init View Issue
• ‼️ App Hanging: App hanging for at least 2000 ms. LegacyUserMigration View Issue
• ‼️ App Hanging: App hanging for at least 2000 ms. NSUserDefaults.bool View Issue
• ‼️ App Hanging: App hanging for at least 2000 ms. $sScTss5NeverORs_rlE8priority9operationScTyxABG... View Issue

_{Did you find this useful? React with a 👍 or 👎}