Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlights - Swipe from the trailing edge to highlight an entire paragraph #974

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

Gio2018
Copy link
Collaborator

@Gio2018 Gio2018 commented Mar 20, 2024

Summary

  • This PR enables highlight on swipe, which allows yo highlight an entire paragraph in the reader by swiping from the trailing edge.

References

  • Branch name

Implementation Details

  • Transform the reader section into a list
  • Add a trailing swipe action that will trigger highlight on the entire text of the paragraph
  • Set preferred content sizes explicitly for any component that downloads content asynchronously

Test Steps

  • Open a saved item, swipe from the trailing edge and make sure the text of the corresponding paragraph is highlighted

Note

as of now, we only support highlighting of paragraphs that do not contain highlights
also, removing highlights by swipe is not yet supported.

PR Checklist:

  • Added Unit / UI tests
  • Self Review (review, clean up, documentation, run tests)
  • Basic Self QA

@pocket-ci
Copy link
Contributor

pocket-ci commented Mar 20, 2024

Messages
📖 No SwiftLint violations! 🎉
📖 Project coverage: 38.76%
📖 Checking XCode Environment Variables
📖 Edited 6 files
📖 Created 1 files

PocketKit: Coverage: 62.14

File Coverage
VimeoComponentCell.swift 0.0% ⚠️
VimeoComponentPresenter.swift 0.0% ⚠️
ReadableViewController.swift 68.17%
YouTubeVideoComponentCell.swift 86.09%
ImageComponentCell.swift 86.96%

PocketKitTests: Coverage: 28.26

File Coverage
YouTubeVideoComponentCell.swift 85.22%
VimeoComponentPresenter.swift 0.0% ⚠️
ReadableViewController.swift 71.94%
ImageComponentCell.swift 90.58%
VimeoComponentCell.swift 0.0% ⚠️

Generated by 🚫 Danger Swift against 5da56d9

@Gio2018 Gio2018 changed the title feat(highlights): adopt list layout in ReadableViewController and pre… Highlights - Swipe from the trailing edge to highlight an entire paragraph Mar 20, 2024
@Gio2018 Gio2018 self-assigned this Mar 20, 2024
@Gio2018 Gio2018 marked this pull request as ready for review March 20, 2024 22:06
@Gio2018 Gio2018 requested a review from bassrock as a code owner March 20, 2024 22:06
Copy link
Collaborator

@nzeltzer nzeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Gio2018 Gio2018 merged commit 7273087 into develop Mar 20, 2024
8 checks passed
@Gio2018 Gio2018 deleted the feat/POCKET-9340-highlight-on-swipe branch March 20, 2024 22:38
Copy link

sentry-io bot commented Mar 21, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ App Hanging: App hanging for at least 2000 ms. ReaderSettings View Issue
  • ‼️ App Hanging: App hanging for at least 2000 ms. NSAttributedStringKey View Issue
  • ‼️ App Hanging: App hanging for at least 2000 ms. NSMutableAttributedString.updateStyle View Issue
  • ‼️ App Hanging: App hanging for at least 2000 ms. ReaderSettings.fontSizeAdjustment.getter View Issue
  • ‼️ App Hanging: App hanging for at least 2000 ms. UIFont.init View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants