Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shortUrl to saved items shares #965

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Conversation

Gio2018
Copy link
Collaborator

@Gio2018 Gio2018 commented Mar 13, 2024

Summary

  • This PR fixes sharing from saved item list that was still stating the full url

References

  • na

Implementation Details

  • see description

Test Steps

  • Share from saves list and make sure its a short url

PR Checklist:

  • Added Unit / UI tests
  • Self Review (review, clean up, documentation, run tests)
  • Basic Self QA

Screenshots

@Gio2018 Gio2018 requested a review from bassrock as a code owner March 13, 2024 23:23
@Gio2018 Gio2018 merged commit 0e2fe00 into develop Mar 13, 2024
1 check failed
@Gio2018 Gio2018 deleted the fix/short-url-saveditem branch March 13, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants