Share: update shortUrl on demand, if needed, when sharing an url

[Gio2018]

Summary

• This PR fetches shortUrl if it's nil before sharing an item, in order to ensure we share shortUrl every time we can

References

• Branch name

Implementation Details

• Add graphQl query to fetch an Item's shortUrl
• Use it to update shortUrl if nil, when sharing an item: this can happen when users migrate from previous versions to 8.5.0

Test Steps

• Install the production (App Store) version and perform a refresh
• Within 5 minutes, install this branch as an upgrade (do not delete the prod version)
• Put a breakpoint where the share logic happens, for example here
• verify that shortUrl is nil
• put another breakpoint here and verify that the shortUrl has been fetched and assigned to the corresponding item
• verify that share works properly, and that you are actually sharing a pocket.co url

PR Checklist:

• Added Unit / UI tests
• Self Review (review, clean up, documentation, run tests)
• Basic Self QA

[bassrock]

approving, but have a few questions around the async behavior

[bassrock]

Is there a risk of no short url by the time the user saves?

[Gio2018]

see slack discussion, short answer: probably not a lot of real world cases, except offline users sharing via airdrop, where we would share the original url anyway.

[bassrock]

Does this work since its ui and needs main thread?

[Gio2018]

it does because HomeViewModel is marked as @MainActor

[sentry-io]

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

• ‼️ App Hanging: App hanging for at least 2000 ms. HomeViewController View Issue

_{Did you find this useful? React with a 👍 or 👎}