Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI tests - fix some fixtures and update button identifiers #961

Merged
merged 4 commits into from
Mar 8, 2024
Merged

UI tests - fix some fixtures and update button identifiers #961

merged 4 commits into from
Mar 8, 2024

Conversation

Gio2018
Copy link
Collaborator

@Gio2018 Gio2018 commented Mar 7, 2024 •
edited
Loading

Summary

  • Some UI tests were failing because of fixtures and button identifiers needing updates

References

  • NA

Implementation Details

  • see summary and code changes

Test Steps

  • Run UI tests locally and make sure they pass

PR Checklist:

  • Added Unit / UI tests
  • Self Review (review, clean up, documentation, run tests)
  • Basic Self QA

Screenshots

@pocket-ci
Copy link
Contributor

Messages
📖 No SwiftLint violations! 🎉
📖 Project coverage: 41.15%
📖 Checking XCode Environment Variables
📖 Edited 4 files
📖 Created 0 files

Tests iOS.xctest: Coverage: 29.85

File Coverage
ReaderToolbarElement.swift 66.67% ✅
ReaderElement.swift 12.75% ⚠️

Generated by 🚫 Danger Swift against 6d9bd23

@Gio2018 Gio2018 changed the title fix(tests): add missing shortUrl in fixture UI tests - fix some fixtures and update button identifiers Mar 8, 2024
@Gio2018 Gio2018 marked this pull request as ready for review March 8, 2024 20:16
@Gio2018 Gio2018 requested a review from bassrock as a code owner March 8, 2024 20:16
@Gio2018 Gio2018 self-assigned this Mar 8, 2024
@Gio2018 Gio2018 merged commit 6bb4af5 into develop Mar 8, 2024
3 of 8 checks passed
@Gio2018 Gio2018 deleted the fix/tests branch March 8, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bassrock bassrock bassrock approved these changes

Assignees

@Gio2018 Gio2018

Labels
ui tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gio2018 @pocket-ci @bassrock