In 1504: Readable Width for Saves and Search #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
May 29, 2023 11:00
… to changing sizeClasses
… subclass to hold constraint logic
CMasterson
requested review from
cyndichin and
Gio2018
and removed request for
a team
PocketKit: Coverage: 76.38
Generated by 🚫 Danger Swift against 9455171 |
cyndichin
reviewed
May 31, 2023
| @@ -325,6 +325,7 @@ extension ReadableViewController { | |||
| // Zero out the default leading/trailing contentInsets, but preserve the default top/bottom values. | |||
| // This ensures each section will be inset horizontally exactly to the readable content width. | |||
| var contentInsets = section.contentInsets | |||
| print("== contentInset \(contentInsets)") | |||
cyndichin
approved these changes
May 31, 2023
|
Updated the SwiftUI ReadableWidth mimic to 700 points, seems to work well on iPad. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds readable width to Saves and mimics it for Search.
References
https://getpocket.atlassian.net/browse/IN-1504
Implementation Details
Saves is built on UIKit and so we are able to add
section.contentInsetsReference = .readableContentto the content cells layout config.Search is built using SwiftUI, which does not appear to have a readableContent setting.
Therefore, if the interface width size class is .regular we restrict the list width to a preset amount (currently 500 points)
Test Steps
Launch and use Saves and Search as normal.
On iPad you may then enable split screen and while changing the window size you will notice the views adapt to their width.
iPhones do not have a landscape layout for Search and Saves, only Reader which already uses Readable Width.
PR Checklist:
Screenshots