Article - Fix a crash when attempting to load a video with an invalid URL #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r throw an error if src is not a valid url
…ideoComponent initializer
Gio2018
force-pushed
the
fix/IN-1451-crash-invalid-video-url
branch
from
a72a9e4 to
e06aa47
Compare
cyndichin
reviewed
May 9, 2023
| @@ -1,4 +1,6 @@ | |||
| import Foundation | |||
There was a problem hiding this comment.
do we need Foundation here?
There was a problem hiding this comment.
Yes (URL)
Actually, good catch! It's a leftover 😄
cyndichin
reviewed
May 9, 2023
Sync: Coverage: 84.56
Generated by 🚫 Danger Swift against e06aa47 |
Gio2018
changed the title
Gio2018
requested review from
cyndichin and
timc-mozilla
and removed request for
a team
cyndichin
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
VideoComponentinstance with an invalid urlReferences
Implementation Details
VideoComponent, make the convenience initializer throw an error if the url fromVideoPartsis invalidArticleComponent, handle the errors described in the previous bulletTest Steps
PR Checklist:
Screenshots