-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sentry): adding profiling #721
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nzeltzer
approved these changes
May 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 🤞
PocketKit: Coverage: 76.13
SharedPocketKit: Coverage: 85.87
Generated by 🚫 Danger Swift against dfff24b |
Waiting on an answer from Sentry about how to do change options after we initialize the SDK |
kschelonka
added a commit
to Pocket/pocket-monorepo
that referenced
this pull request
Sep 30, 2024
kschelonka
added a commit
to Pocket/pocket-monorepo
that referenced
this pull request
Sep 30, 2024
kschelonka
added a commit
to Pocket/pocket-monorepo
that referenced
this pull request
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add in Sentry profiling.
Implementation Details
We have made this setup a feature flag so that we can enable and disable Sentry profiling at will due to our Sentry contract supporting a limited number of "profile" traces. Note that the value is controlled via the Payload of the feature flag. We will set this up to 0.25 (25%) for traceSampling and 0.50 (50%) for profileSampling
Note that profile sampling is relative to traceSampling:
Note Feature Flags only update values once every 48 hours, currently asking SRE if we need to change this cadence and asking android what they do.