Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sentry): adding profiling #721

Merged
merged 11 commits into from
May 11, 2023
Merged

fix(sentry): adding profiling #721

merged 11 commits into from
May 11, 2023

Conversation

bassrock
Copy link
Contributor

@bassrock bassrock commented May 9, 2023

Summary

Add in Sentry profiling.

Implementation Details

We have made this setup a feature flag so that we can enable and disable Sentry profiling at will due to our Sentry contract supporting a limited number of "profile" traces. Note that the value is controlled via the Payload of the feature flag. We will set this up to 0.25 (25%) for traceSampling and 0.50 (50%) for profileSampling

Note that profile sampling is relative to traceSampling:

IE. if tracesSampler responds with 100%, profilesSampler will be called 100% of the time,
            // if traces responds with 50%, profileSamples will be called 50% of the time.

Note Feature Flags only update values once every 48 hours, currently asking SRE if we need to change this cadence and asking android what they do.

@bassrock bassrock requested a review from a team as a code owner May 9, 2023 00:12
@bassrock bassrock requested review from Gio2018 and timc-mozilla and removed request for a team May 9, 2023 00:12
Copy link
Collaborator

@nzeltzer nzeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🤞

@pocket-ci
Copy link
Contributor

pocket-ci commented May 9, 2023

Messages
📖 No SwiftLint violations! 🎉
📖 Project coverage: 75.98%
📖 Checking XCode Environment Variables
📖 Edited 5 files
📖 Created 1 files

PocketKit: Coverage: 76.13

File Coverage
PocketAppDelegate.swift 72.14%
FeatureFlagsRefreshCoordinator.swift 38.98% ⚠️
FeatureFlagService.swift 26.53% ⚠️

SharedPocketKit: Coverage: 85.87

File Coverage
String+Number.swift 0.0% ⚠️
Log.swift 86.45%

Generated by 🚫 Danger Swift against dfff24b

@bassrock bassrock marked this pull request as draft May 9, 2023 19:14
@bassrock
Copy link
Contributor Author

Waiting on an answer from Sentry about how to do change options after we initialize the SDK

@bassrock bassrock marked this pull request as ready for review May 10, 2023 22:03
@bassrock bassrock merged commit 6fb6b9d into develop May 11, 2023
@bassrock bassrock deleted the sentry-profiling branch May 11, 2023 16:38
kschelonka added a commit to Pocket/pocket-monorepo that referenced this pull request Sep 30, 2024
kschelonka added a commit to Pocket/pocket-monorepo that referenced this pull request Sep 30, 2024
kschelonka added a commit to Pocket/pocket-monorepo that referenced this pull request Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants