You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added basic debug menu to Settings that shows user identifier and sets up UI for snowplow configuration and feature flag values.
Test Steps
Add your user ID to https://featureflags.readitlater.com/projects/default/features/perm.ios.debug.menu if you would like the debug menu feature flag to be turned on
Navigate to Settings and view the Debug Menu as shown in screenshot
PR Checklist:
N / A Added Unit / UI tests
Self Review (review, clean up, documentation, run tests)
The only other real comment I have is that we're utilizing the Services.shared singleton within a view, rather than passing down any dependencies in as a dependency, but this is a debug view and I don't think that's something to think too hard about. Just pointing it out.
The only other real comment I have is that we're utilizing the Services.shared singleton within a view, rather than passing down any dependencies in as a dependency, but this is a debug view and I don't think that's something to think too hard about. Just pointing it out.
good point! Thought it might add overhead so didn't add a view model or inject the dependencies. thanks!
@dskuza imagine one of many possible futures when we get to SwiftUI we could set all the services as environment variables if we wanted and just yoink them out 😬
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cyndichin
requested review from
nzeltzer and
CMasterson
and removed request for
a team
Summary
PR to add debug menu to iOS app
References
N / A
Implementation Details
Added basic debug menu to Settings that shows user identifier and sets up UI for snowplow configuration and feature flag values.
Test Steps
https://featureflags.readitlater.com/projects/default/features/perm.ios.debug.menuif you would like the debug menu feature flag to be turned onPR Checklist:
Screenshots