test(sync) Add tests to run fetchSaves and fetchArchive at the same t… #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ime on 2 threads. Fix crash in mockOperationFactory
CMasterson
requested review from
dskuza and
nzeltzer
and removed request for
a team
bassrock
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ime on 2 threads. Fix crash in mockOperationFactory
Summary
When in the background the app may try to fetch saves and archive at the same time, from 2 different threads with can cause a crash.
@bassrock guided me through adding childContexts for those operations which fixes the crash.
References
https://pocket.sentry.io/issues/4156754439/events/9e85fa2a05f34a739fbd45c63a5ced53/
https://pocket.sentry.io/issues/4156756592/events/83a8ff1dddad4e4e8805329aa7049c80/
Implementation Details
Added a childContext in the PocketSource enqueue function to avoid collisions between threads.
Also, to fix a crash in MockOperationFactory, we wrapped the fetchArchiveCall assignment in a DispatchQueue .sync
Test Steps
The crash happens in the background, so testing seems nigh-impossible.
PR Checklist: