fix(ui): dark mode buttons + color #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PocketKit: Coverage: 77.7
Generated by 🚫 Danger Swift against 639249a |
cyndichin
force-pushed
the
fix/IN-1393_dark-mode-designs-button
branch
2 times, most recently
from
981382b to
9ac6b3b
Compare
cyndichin
force-pushed
the
fix/IN-1393_dark-mode-designs-button
branch
from
9ac6b3b to
639249a
Compare
cyndichin
changed the title
cyndichin
commented
May 4, 2023
| @@ -3,7 +3,7 @@ import SwiftUI | |||
| struct ActionsPrimaryButtonStyle: ButtonStyle { | |||
| func makeBody(configuration: Configuration) -> some View { | |||
| configuration.label | |||
| .background(configuration.isPressed ? Color(.ui.teal1) : Color(.ui.teal2)) | |||
| .background(configuration.isPressed ? Color(UIColor(.ui.teal1).resolvedColor(with: UITraitCollection(userInterfaceStyle: .light))) : Color(UIColor(.ui.teal2).resolvedColor(with: UITraitCollection(userInterfaceStyle: .light)))) | |||
There was a problem hiding this comment.
we should probably consolidate this style and PocketButtonStyle, but need to discuss with Tais on this as they are different sized buttons. out of scope for this ticket
cyndichin
requested review from
dskuza and
nzeltzer
and removed request for
a team
dskuza
approved these changes
May 4, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Button color should be the same as light mode and
teal2color in dark mode should be adjusted.References
IN-1393
Implementation Details
As part of this work:
teal2dark mode to use#9AE2DE13to buttonsTest Steps
Verify that dark mode buttons are now same color as light mode buttons
PR Checklist:
Screenshots