In 1361- Search Overflow Actions #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 1, 2023 11:31
…kes an action from the overflow menu
CMasterson
requested review from
dskuza and
Gio2018
and removed request for
a team
bassrock
approved these changes
May 1, 2023
PocketKit: Coverage: 76.83
Generated by 🚫 Danger Swift against 8a72b5f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When a user un/archives a search result from the overflow menu, update the displayed results.
References
https://getpocket.atlassian.net/browse/IN-1361
Implementation Details
Added SearchResultsActionDelegate with the SearchResultsViewModel conforming to it.
PocketItemViewModel is passed a weak reference to the delegate and attempts to call it when the user takes an action from the overflow menu.
Test Steps
Search for any item
Using the overflow menu ( '...' button) un/archive the item.
The item disappears from the search results if searching Save/Archive but has no effect when searching All Items
PR Checklist: