Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widgets improvements #1148

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Widgets improvements #1148

merged 2 commits into from
Feb 3, 2025

Conversation

Gio2018
Copy link
Collaborator

@Gio2018 Gio2018 commented Feb 3, 2025

Goal

  • Remove the unused static recommendations widget
  • Update the recent saves widget when users log in/out

Test Steps

  • Build/run this branch
  • login
  • Install recommendations and recent saves widgets and make sure they display content
  • Make sure the recommendations widget is configurable by long pressing and choosing a topic
  • Logout
  • Make sure the recent saves displays the logged out message

@Gio2018 Gio2018 added bug Something isn't working widgets labels Feb 3, 2025
@Gio2018 Gio2018 added this to the 8.26.0 milestone Feb 3, 2025
@Gio2018 Gio2018 requested a review from nzeltzer February 3, 2025 18:47
@Gio2018 Gio2018 self-assigned this Feb 3, 2025
Copy link
Collaborator

@nzeltzer nzeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@pocket-ci
Copy link
Contributor

Messages
📖 No SwiftLint violations! 🎉
📖 Project coverage: 35.76%
📖 Checking XCode Environment Variables
📖 Edited 5 files
📖 Created 0 files

PocketKit: Coverage: 58.93

File Coverage
HomeView.swift 93.75%

Sync: Coverage: 68.33

File Coverage
RecommendationsWidgetsUpdateService.swift 96.55%

SyncTests: Coverage: 20.37

File Coverage
RecommendationsWidgetsUpdateService.swift 91.38%

ItemWidgets.appex: Coverage: 0.0

File Coverage
TopicRecommendationsWidget.swift 0.0% ⚠️

PocketKitTests: Coverage: 22.94

File Coverage
HomeView.swift 94.64%

Generated by 🚫 Danger Swift against 74d5f7a

@Gio2018 Gio2018 merged commit d5184e8 into develop Feb 3, 2025
4 of 8 checks passed
@Gio2018 Gio2018 deleted the recommendations-widget branch February 3, 2025 19:49
Copy link

sentry-io bot commented Feb 6, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ App Hanging Fully Blocked: App hanging for at least 2000 ms. closure in HomeView.body.getter View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working widgets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants