Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new Recommendations widget tip displaying at every launch #1000

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

Gio2018
Copy link
Collaborator

@Gio2018 Gio2018 commented Apr 29, 2024

Summary

  • This PR fixes a beta issue where the new Recommendations widget tip would show at every launch

References

  • Branch name

Implementation Details

  • Add Tips.Events to vend the tips, to have better control on when to display them

Test Steps

  • build/run, make sure the new recommendations tip only shows once, regardless how you dismiss it

PR Checklist:

  • Added Unit / UI tests
  • Self Review (review, clean up, documentation, run tests)
  • Basic Self QA

Screenshots

@Gio2018 Gio2018 added bug Something isn't working Tips labels Apr 29, 2024
@Gio2018 Gio2018 added this to the 8.8.0 milestone Apr 29, 2024
@Gio2018 Gio2018 self-assigned this Apr 29, 2024
@Gio2018 Gio2018 marked this pull request as ready for review April 29, 2024 21:55
@Gio2018 Gio2018 requested a review from bassrock as a code owner April 29, 2024 21:55
@Gio2018 Gio2018 requested a review from nzeltzer April 29, 2024 21:55
@pocket-ci
Copy link
Contributor

Messages
📖 No SwiftLint violations! 🎉
📖 Project coverage: 36.43%
📖 Checking XCode Environment Variables
📖 Edited 5 files
📖 Created 0 files

PocketKit: Coverage: 61.79

File Coverage
ItemsListViewController.swift 77.36%
HomeViewController.swift 61.22%
TippableViewController.swift 47.0% ⚠️
ReadableViewController.swift 62.82%
PocketTips.swift 100.0%

PocketKitTests: Coverage: 28.37

File Coverage
HomeViewController.swift 46.81% ⚠️
PocketTips.swift 100.0%
ReadableViewController.swift 65.23%
ItemsListViewController.swift 67.3%
TippableViewController.swift 71.0%

Generated by 🚫 Danger Swift against f9fd7fa

@Gio2018 Gio2018 merged commit 150e134 into develop Apr 29, 2024
5 of 8 checks passed
@Gio2018 Gio2018 deleted the fix/POCKET-10030-multiple-tips branch April 29, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Tips
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants