fix(tests): update tests after making item optional

Pocket · May 2, 2023 · 3120789 · 3120789
1 parent 21f5cca
commit 3120789
Show file tree

Hide file tree

Showing 5 changed files with 24 additions and 24 deletions.
diff --git a/PocketKit/Tests/PocketKitTests/SavedItemViewModelTests.swift b/PocketKit/Tests/PocketKitTests/SavedItemViewModelTests.swift
@@ -101,7 +101,7 @@ class SavedItemViewModelTests: XCTestCase {
         source.stubFetchDetails { _ in }
 
         let savedItem = space.buildSavedItem()
-        savedItem.item.article = nil
+        savedItem.item?.article = nil
         try space.save()
 
         let viewModel = subject(item: savedItem)

diff --git a/PocketKit/Tests/PocketKitTests/SlateDetailViewModelTests.swift b/PocketKit/Tests/PocketKitTests/SlateDetailViewModelTests.swift
@@ -137,7 +137,7 @@ class SlateDetailViewModelTests: XCTestCase {
 
     func test_selectCell_whenSelectingRecommendation_recommendationIsReadable_updatesSelectedReadable() throws {
         let savedItem = try space.createSavedItem(item: space.buildItem())
-        let recommendation = space.buildRecommendation(item: savedItem.item)
+        let recommendation = space.buildRecommendation(item: savedItem.item!)
         let slate = try space.createSlate(recommendations: [recommendation])
         try space.save()
         let viewModel = subject(slate: space.viewObject(with: slate.objectID) as! Slate)

diff --git a/PocketKit/Tests/SyncTests/Operations/SaveItemOperationTests.swift b/PocketKit/Tests/SyncTests/Operations/SaveItemOperationTests.swift
@@ -71,7 +71,7 @@ class SaveItemOperationTests: XCTestCase {
         XCTAssertEqual(performCall?.mutation.input.url, url.absoluteString)
 
         let item = try space.fetchSavedItem(byURL: url)
-        XCTAssertEqual(savedItem.item.resolvedURL, URL(string: "https://resolved.example.com/item-1")!)
+        XCTAssertEqual(savedItem.item?.resolvedURL, URL(string: "https://resolved.example.com/item-1")!)
         XCTAssertNotNil(item)
     }
 

diff --git a/PocketKit/Tests/SyncTests/PocketSourceTests.swift b/PocketKit/Tests/SyncTests/PocketSourceTests.swift
@@ -189,7 +189,7 @@ class PocketSourceTests: XCTestCase {
         }
 
         let savedItem = try space.createSavedItem(item: space.buildItem())
-        let item = savedItem.item
+        let item = savedItem.item!
         item.recommendation = space.buildRecommendation(item: item)
 
         let remoteItemURL = item.givenURL
@@ -207,7 +207,7 @@ class PocketSourceTests: XCTestCase {
         }
 
         let savedItem = try space.createSavedItem(item: space.buildItem())
-        let item = savedItem.item
+        let item = savedItem.item!
 
         let remoteItemURL = item.givenURL
 
@@ -354,7 +354,7 @@ class PocketSourceTests: XCTestCase {
 
         let savedItem = savedItems[0]
         XCTAssertEqual(savedItem.objectID, seededSavedItem.objectID)
-        XCTAssertEqual(savedItem.item.objectID, seededItem.objectID)
+        XCTAssertEqual(savedItem.item?.objectID, seededItem.objectID)
         XCTAssertFalse(savedItem.isArchived)
     }
 
@@ -701,8 +701,8 @@ extension PocketSourceTests {
         let savedItem = source.fetchOrCreateSavedItem(with: URL(string: "http://localhost:8080/hello")!, and: itemParts)
 
         XCTAssertEqual(savedItem?.remoteID, "saved-item")
-        XCTAssertEqual(savedItem?.item.title, "item-title")
-        XCTAssertEqual(savedItem?.item.bestURL.absoluteString, "http://localhost:8080/hello")
+        XCTAssertEqual(savedItem?.item?.title, "item-title")
+        XCTAssertEqual(savedItem?.item?.bestURL.absoluteString, "http://localhost:8080/hello")
     }
 
     private func setupLocalSavesSearch(with urlString: String? = nil) throws {

diff --git a/PocketKit/Tests/SyncTests/Support/FetchSavesTests.swift b/PocketKit/Tests/SyncTests/Support/FetchSavesTests.swift
@@ -104,33 +104,33 @@ class FetchSavesTests: XCTestCase {
         XCTAssertEqual(tags?[0].name, "tag-1")
 
         let item = savedItem.item
-        XCTAssertEqual(item.remoteID, "item-1")
-        XCTAssertEqual(item.givenURL, URL(string: "https://given.example.com/item-1")!)
-        XCTAssertEqual(item.resolvedURL, URL(string: "https://resolved.example.com/item-1")!)
-        XCTAssertEqual(item.title, "Item 1")
-        XCTAssertEqual(item.topImageURL, URL(string: "https://example.com/item-1/top-image.jpg")!)
-        XCTAssertEqual(item.domain, "example.com")
-        XCTAssertEqual(item.language, "en")
-        XCTAssertEqual(item.timeToRead, 6)
-        XCTAssertEqual(item.excerpt, "Cursus Aenean Elit")
-        XCTAssertEqual(item.datePublished, Date(timeIntervalSinceReferenceDate: 631195261))
+        XCTAssertEqual(item?.remoteID, "item-1")
+        XCTAssertEqual(item?.givenURL, URL(string: "https://given.example.com/item-1")!)
+        XCTAssertEqual(item?.resolvedURL, URL(string: "https://resolved.example.com/item-1")!)
+        XCTAssertEqual(item?.title, "Item 1")
+        XCTAssertEqual(item?.topImageURL, URL(string: "https://example.com/item-1/top-image.jpg")!)
+        XCTAssertEqual(item?.domain, "example.com")
+        XCTAssertEqual(item?.language, "en")
+        XCTAssertEqual(item?.timeToRead, 6)
+        XCTAssertEqual(item?.excerpt, "Cursus Aenean Elit")
+        XCTAssertEqual(item?.datePublished, Date(timeIntervalSinceReferenceDate: 631195261))
 
         let expected: [ArticleComponent] = Fixture.load(name: "marticle").decode()
-        XCTAssertEqual(item.article?.components, expected)
+        XCTAssertEqual(item?.article?.components, expected)
 
-        let authors = item.authors?.compactMap { $0 as? Author }
+        let authors = item?.authors?.compactMap { $0 as? Author }
         XCTAssertEqual(authors?[0].id, "author-1")
         XCTAssertEqual(authors?[0].name, "Eleanor")
         XCTAssertEqual(authors?[0].url, URL(string: "https://example.com/authors/eleanor")!)
 
-        let domain = item.domainMetadata
+        let domain = item?.domainMetadata
         XCTAssertEqual(domain?.name, "WIRED")
         XCTAssertEqual(domain?.logo, URL(string: "http://example.com/item-1/domain-logo.jpg")!)
 
-        let images = item.images?.compactMap { $0 as? Image } ?? []
+        let images = item?.images?.compactMap { $0 as? Image } ?? []
         XCTAssertEqual(images[0].source, URL(string: "http://example.com/item-1/image-1.jpg"))
 
-        XCTAssertEqual(item.syndicatedArticle?.itemID, "syndicated-article-item-id")
+        XCTAssertEqual(item?.syndicatedArticle?.itemID, "syndicated-article-item-id")
     }
 
     func test_refresh_whenFetchSucceeds_andResultContainsDuplicateItems_createsSingleItem() async throws {
@@ -157,7 +157,7 @@ class FetchSavesTests: XCTestCase {
         _ = await service.execute(syncTaskId: task.objectID)
 
         let item = try space.fetchSavedItem(byURL: URL(string: "http://example.com/item-1")!)
-        XCTAssertEqual(item?.item.title, "Updated Item 1")
+        XCTAssertEqual(item?.item?.title, "Updated Item 1")
     }
 
     func test_refresh_whenFetchFails_sendsErrorOverGivenSubject() async throws {