update PersonCard null

PoApper · Oct 8, 2023 · c3e7666 · c3e7666
1 parent 767bb8d
commit c3e7666
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 6 deletions.
diff --git a/src/components/people/person-card.jsx b/src/components/people/person-card.jsx
@@ -105,10 +105,11 @@ const PersonCard = ({
             <FaHome size="1.75rem" />
           </Link>
         ) : null}
-
-        <Link href={`https://github.com/${githubUsername}`} target="_blank">
-          <FaGithub size="1.75rem" />
-        </Link>
+        {githubUsername ? (
+          <Link href={`https://github.com/${githubUsername}`} target="_blank">
+            <FaGithub size="1.75rem" />
+          </Link>
+        ) : null}
       </Links>
     </Container>
   )

diff --git a/src/pages/people.jsx b/src/pages/people.jsx
@@ -23,12 +23,16 @@ const PeoplePage = () => {
           .sort((a, b) => a.priority - b.priority)
           .map(person => (
             <PersonCard
-              image={`https://avatars.githubusercontent.com/${[person.github]}`}
+              image={
+                person.github_id
+                  ? `https://avatars.githubusercontent.com/${person.github_id}`
+                  : "https://raw.githubusercontent.com/PoApper/poapper-asset/main/logo/logo.png"
+              }
               name={person.name}
               tags={person.tags}
               text={person.text}
               website={person.website}
-              githubUsername={person.github}
+              githubUsername={person.github_id}
               badges={person.badge}
             />
           ))}