Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPORT] [MONITORING] feat: move dataset selection to the fieldmapping step #3289

Draft
wants to merge 12 commits into
base: feat/import-monitorings
Choose a base branch
from

Conversation

edelclaux
Copy link
Contributor

Issue: https://github.com/orgs/PnX-SI/projects/13/views/15?pane=issue&itemId=83598187

Dans ce travail, on se concentre sur le déplacement de la sélection du dataset à l'endroit du fieldmapping.

Il reste à traiter:

  • la maj des tests backend
  • la maj des tests frontend
  • un passage sur le double champ: uuid dataset + id dataset --> pourquoi, lequel on veut ?
  • l'utilisation d'un widget 'pnx-dataset' dans la section field mapping

@edelclaux edelclaux force-pushed the feat-import/select-dataset-as-other-fields branch 3 times, most recently from 364cccd to d83e804 Compare December 16, 2024 14:46
@edelclaux edelclaux marked this pull request as draft December 16, 2024 14:48
@edelclaux edelclaux force-pushed the feat-import/select-dataset-as-other-fields branch from 64ef6d2 to dda88a8 Compare December 17, 2024 16:11
@edelclaux edelclaux force-pushed the feat-import/select-dataset-as-other-fields branch from b351a4f to bb72f06 Compare January 2, 2025 15:35
@jacquesfize jacquesfize force-pushed the feat/import-monitorings branch from 2b5f26f to dcc764e Compare January 3, 2025 12:39
@edelclaux edelclaux force-pushed the feat-import/select-dataset-as-other-fields branch from 57d8865 to c9ec357 Compare January 3, 2025 17:49
@Pierre-Narcisi Pierre-Narcisi force-pushed the feat/import-monitorings branch from 719b85f to bfcf4a7 Compare January 20, 2025 16:12
@edelclaux edelclaux force-pushed the feat-import/select-dataset-as-other-fields branch 5 times, most recently from 93b0fde to 560542e Compare January 23, 2025 11:00
@edelclaux edelclaux force-pushed the feat-import/select-dataset-as-other-fields branch from 560542e to bbd37c8 Compare January 23, 2025 11:03
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.14%. Comparing base (d655a53) to head (7b3a8b3).

Additional details and impacted files
@@                     Coverage Diff                     @@
##           feat/import-monitorings    #3289      +/-   ##
===========================================================
+ Coverage                    84.03%   84.14%   +0.10%     
===========================================================
  Files                          122      122              
  Lines                         9742     9723      -19     
===========================================================
- Hits                          8187     8181       -6     
+ Misses                        1555     1542      -13     
Flag Coverage Δ
pytest 84.14% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edelclaux edelclaux force-pushed the feat-import/select-dataset-as-other-fields branch from 529de13 to 13d7d66 Compare January 28, 2025 10:46
@edelclaux edelclaux force-pushed the feat-import/select-dataset-as-other-fields branch from 13d7d66 to 3c7bb34 Compare January 28, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant