Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(import) : Clean code before merge #3238

Merged
merged 19 commits into from
Oct 28, 2024
Merged

feat(import) : Clean code before merge #3238

merged 19 commits into from
Oct 28, 2024

Conversation

jacquesfize
Copy link
Contributor

@jacquesfize jacquesfize commented Oct 24, 2024

TODO

  • Issue with the altitude_min field for the occhab import
  • Find the mean to remove redis from the pytest actions

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 73.86364% with 46 lines in your changes missing coverage. Please review.

Project coverage is 83.86%. Comparing base (c1b99c3) to head (ea1d77d).
Report is 1 commits behind head on feat/import.

Files with missing lines Patch % Lines
backend/geonature/core/gn_synthese/imports/plot.py 26.08% 34 Missing ⚠️
backend/geonature/core/imports/models.py 64.28% 10 Missing ⚠️
...kend/geonature/core/gn_synthese/imports/actions.py 94.73% 1 Missing ⚠️
backend/geonature/core/imports/commands.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           feat/import    #3238      +/-   ##
===============================================
+ Coverage        83.83%   83.86%   +0.03%     
===============================================
  Files              121      122       +1     
  Lines             9619     9646      +27     
===============================================
+ Hits              8064     8090      +26     
- Misses            1555     1556       +1     
Flag Coverage Δ
pytest 83.86% <73.86%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jacquesfize and others added 3 commits October 25, 2024 10:14
Co-authored-by: Élie Bouttier <bouttier@users.noreply.github.com>
@jacquesfize jacquesfize marked this pull request as ready for review October 28, 2024 09:02
@jacquesfize jacquesfize merged commit 33caae6 into feat/import Oct 28, 2024
7 checks passed
@jacquesfize jacquesfize deleted the clean_code branch October 28, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants