-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(import) : Clean code before merge #3238
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/import #3238 +/- ##
===============================================
+ Coverage 83.83% 83.86% +0.03%
===============================================
Files 121 122 +1
Lines 9619 9646 +27
===============================================
+ Hits 8064 8090 +26
- Misses 1555 1556 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bouttier
approved these changes
Oct 25, 2024
contrib/gn_module_occhab/backend/gn_module_occhab/imports/actions.py
Outdated
Show resolved
Hide resolved
contrib/gn_module_occhab/backend/gn_module_occhab/imports/actions.py
Outdated
Show resolved
Hide resolved
…ransform query in SQLA 2.0
Co-authored-by: Élie Bouttier <bouttier@users.noreply.github.com>
…id in statistics + minor corrections in import list UI
Pierre-Narcisi
force-pushed
the
feat/import
branch
from
October 28, 2024 13:44
46a4735
to
a487cfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
altitude_min
field for the occhab importredis
from the pytest actions