Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (import) : hide jdd selection form #3206

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Conversation

jacquesfize
Copy link
Contributor

@jacquesfize jacquesfize commented Sep 30, 2024

This PR just hide the JDD selection form in during the mapping step. Since, JDD can now be selected in different steps of the process (#3129), it was decided to hide this one to avoid confusion !

…lay to true.

This is required for testing the dataset mapping field even though it is deactivated for the moment.
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.50%. Comparing base (8502838) to head (5d01eea).
Report is 4 commits behind head on feat/import.

Additional details and impacted files
@@             Coverage Diff              @@
##           feat/import    #3206   +/-   ##
============================================
  Coverage        83.50%   83.50%           
============================================
  Files              121      121           
  Lines             9538     9538           
============================================
  Hits              7965     7965           
  Misses            1573     1573           
Flag Coverage Δ
pytest 83.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacquesfize jacquesfize merged commit 5e42ac1 into feat/import Oct 1, 2024
9 checks passed
@jacquesfize jacquesfize deleted the hide-jdd-form branch October 1, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant