Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add link to taxon sheet in synthese list #3175

Merged

Conversation

edelclaux
Copy link
Contributor

@edelclaux edelclaux commented Sep 4, 2024

Closes #2718

Voir l'issue pour plus de détail sur le sujet développement réalisé.

Il me semble que la réflexion amenait à peu près à ce mini-dev, pour se rendre compte de ce à quoi ça ressemblerait.

Le développement en lui-même est assez sobre, et peut se passer de commentaire.

image

@edelclaux edelclaux marked this pull request as ready for review September 4, 2024 14:14
@camillemonchicourt
Copy link
Member

OK, j'indiquai que ça me semblait viable et un peu moins confusant si c'est aussi ajouté sur le nom du JDD.
Et si possible ajouter un tooltip au survol "Afficher la fiche du taxon".

@edelclaux
Copy link
Contributor Author

J'ai rajouté la tooltip. Je regarderai pour le lien vers metadonnées.

@edelclaux
Copy link
Contributor Author

edelclaux commented Sep 5, 2024

J'ai rajouté le lien vers metadata.
Pour ajouter ce lien, le champ id_dataset a du être rajouté aux champs retournés par le backend.

image

@camillemonchicourt
Copy link
Member

OK pour moi au niveau fonctionnel.

@edelclaux edelclaux force-pushed the feat/synthese-species-hyperlink branch 2 times, most recently from ba07065 to c28e006 Compare September 17, 2024 11:09
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.62%. Comparing base (c3f7f65) to head (b7fcef3).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3175   +/-   ##
========================================
  Coverage    81.62%   81.62%           
========================================
  Files           86       86           
  Lines         6945     6945           
========================================
  Hits          5669     5669           
  Misses        1276     1276           
Flag Coverage Δ
pytest 81.62% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edelclaux edelclaux force-pushed the feat/synthese-species-hyperlink branch from c28e006 to b7fcef3 Compare October 2, 2024 11:22
@jacquesfize jacquesfize merged commit 87c12e9 into PnX-SI:develop Oct 4, 2024
7 checks passed
@edelclaux edelclaux deleted the feat/synthese-species-hyperlink branch October 7, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants