-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/custom authentification #2976
Conversation
d89a39e
to
f46318a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Premier retour, mais je ne suis pas sûr d’avoir tous les tenant et aboutissant, ça serait sans doute plus pratique d’en discuter de vive voix !
Globalement j’ai deux remarques :
- config a laisser plutôt dans
geonature.utils.config
- je serai plutôt partisan que le (ou les) provider soient la ref de module (comme dans django), pour pouvoir facilement importer du code fourni par du code externe, typiquement l’auth INPN.
b841cad
to
c6fa4e7
Compare
8fbb015
to
e09c80e
Compare
83d7592
to
8fe5093
Compare
…PN cas login method
…tom login provider Co-authored-by: TheoLechemia <theo.lechemia@ecrins-parcnational.fr>
…thentification class
bd40158
to
4f32e64
Compare
…nd routes change providers route + change custom.py
1fc5643
to
50d9da5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2976 +/- ##
===========================================
+ Coverage 78.13% 81.63% +3.49%
===========================================
Files 90 85 -5
Lines 7346 6850 -496
===========================================
- Hits 5740 5592 -148
+ Misses 1606 1258 -348
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…ault + default login form can be hidden
…ider cannot access edit user panel
…ation.configuration_schema` method (validation schema is declared and used in `configure`
…n the login component
4a6e80a
to
a56dd23
Compare
Link to issue : #3111
This PR propose to enable the customization of the authentification process in GeoNature. This PR is a work in progress !
TODOLIST :
is_uh
tois_external
name
attr ofAuthentication
)configuration_schema()
method to be deleted --> if validation schema needed, insert it in the configure() method