Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include group3inpn in GeoNature #2880

Merged
merged 23 commits into from
Feb 13, 2024
Merged

Include group3inpn in GeoNature #2880

merged 23 commits into from
Feb 13, 2024

Conversation

jacquesfize
Copy link
Contributor

@jacquesfize jacquesfize commented Jan 26, 2024

Une PR tampon pour tester les différentes PR sur l'ajout du groupe 3 inpn dans GeoNature

PR à intégrer :

In occurrence and counting
Also propagate the new getNomenclature parameter across its uses
Remark: in diff, it seems to have a wrong char between "group2" and "_",
it seems fine though
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (02c84bc) 78.44% compared to head (591e772) 78.43%.

Files Patch % Lines
...nature/core/gn_synthese/utils/query_select_sqla.py 25.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2880      +/-   ##
===========================================
- Coverage    78.44%   78.43%   -0.02%     
===========================================
  Files           89       89              
  Lines         7213     7214       +1     
===========================================
  Hits          5658     5658              
- Misses        1555     1556       +1     
Flag Coverage Δ
pytest 78.43% <25.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacquesfize jacquesfize added this to the 2.14 milestone Feb 9, 2024
andriacap and others added 20 commits February 9, 2024 13:24
Since the Taxref v14 or v15 , group3_inpn is available

Creation of revision in order to add this column to
v_synthese_for_export and v_synthese_taxon_for_export_view

Reviewed-by: andriacap
Reviewed-by: andriacap
test_synthese export

Reviewed-by: andriacap
Reviewed-by: andriacap
Ajout des colonnes group3_inpn à la suite des autres colonnes
Proposition de ré arrangement des fichiers sql

Reviewed-by: andriacap
Use current way to replace view

Reviewed-by: andriacap
Need to have the latest version of Taxhub
Because no need anymore since it is not used by taxonomyGroup3Inpn
@jacquesfize jacquesfize merged commit 3ddf17c into develop Feb 13, 2024
7 of 9 checks passed
@jacquesfize jacquesfize deleted the feat/groupinpn3 branch February 13, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants