Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid sqla polymorphic errors #2792

Merged
merged 1 commit into from
Dec 11, 2023
Merged

avoid sqla polymorphic errors #2792

merged 1 commit into from
Dec 11, 2023

Conversation

bouttier
Copy link
Contributor

When polymorphic modules are declared in database, but absent from venv, this raise a sqlalchemy polymorphic error. This commit fallback missing polymorphic identities on default "base" identity.

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4465b13) 78.57% compared to head (b0fa72c) 78.57%.

Files Patch % Lines
backend/geonature/core/gn_commons/models/base.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2792      +/-   ##
===========================================
- Coverage    78.57%   78.57%   -0.01%     
===========================================
  Files           84       84              
  Lines         6903     6907       +4     
===========================================
+ Hits          5424     5427       +3     
- Misses        1479     1480       +1     
Flag Coverage Δ
pytest 78.57% <75.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

When polymorphic modules are declared in database, but absent from venv,
this raise a sqlalchemy polymorphic error. This commit fallback missing
polymorphic identities on default "base" identity.
@jacquesfize jacquesfize force-pushed the fix/polymorphic-modules branch from 2594bd1 to b0fa72c Compare December 11, 2023 13:34
@jacquesfize jacquesfize merged commit 85d6931 into develop Dec 11, 2023
7 of 9 checks passed
@jacquesfize jacquesfize deleted the fix/polymorphic-modules branch December 11, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants