feat(front): utiliser le localStorage pour stocker le fond cartographique actuel #2620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Store the name of the selected BaseLayer in the local storage, so that it can be set on map creation. Only the name is stored since the actual base layer can be retrieved from it. Checks have been set to prevent errors when the layer does not exist or if the localStorage is empty
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #2620 +/- ##
========================================
Coverage 68.27% 68.27%
========================================
Files 84 84
Lines 7419 7419
========================================
Hits 5065 5065
Misses 2354 2354
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
camillemonchicourt
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ce qui a été fait :
localStoragecar la couche peut-être retrouvée grâce à la variablebaseControllocalStorage. La directivemap.addLayern'ajoute pas la couche si elle existe déjà (voir : https://stackoverflow.com/a/33762133) mais la met à jourlocalStoragevide, nom de la couche introuvableAttention : cette PR ne traite pas du stockage des
REF_LAYERS(ZNIEFF, communes etc), car lourd à afficher et n'a pas vocation, selon moi, à apparaitre constamment sur la carte.Closes #2619