Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

register enhancement #2575

Merged
merged 6 commits into from
Jun 22, 2023
Merged

register enhancement #2575

merged 6 commits into from
Jun 22, 2023

Conversation

joelclems
Copy link
Contributor

@joelclems joelclems commented May 31, 2023 •
edited by camillemonchicourt
Loading

Inscription

@codecov
Copy link

codecov bot commented May 31, 2023 •
edited
Loading

Codecov Report

Patch coverage: 15.38% and project coverage change: -0.08 ⚠️

Comparison is base (42659eb) 68.02% compared to head (90faf93) 67.94%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2575      +/-   ##
===========================================
- Coverage    68.02%   67.94%   -0.08%     
===========================================
  Files           84       84              
  Lines         7389     7397       +8     
===========================================
  Hits          5026     5026              
- Misses        2363     2371       +8
Flag Coverage Δ
pytest 67.94% <15.38%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
backend/geonature/utils/config_schema.py 92.42% <0.00%> (ø)
...kend/geonature/core/users/register_post_actions.py 23.61% <14.28%> (-0.27%) ⬇️
backend/geonature/core/users/routes.py 54.00% <20.00%> (-0.83%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@joelclems joelclems force-pushed the feat/register branch 3 times, most recently from c575742 to 5c7fdd8 Compare June 1, 2023 10:19
@joelclems joelclems marked this pull request as ready for review June 9, 2023 11:46
amandine-sahl
amandine-sahl requested changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@amandine-sahl amandine-sahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est peu être l'occasion de rajouter des tests

backend/geonature/core/users/register_post_actions.py Outdated Show resolved Hide resolved
backend/geonature/core/users/register_post_actions.py Outdated Show resolved Hide resolved
backend/geonature/core/users/templates/email_admin_validate_account.html
@@ -10,6 +10,10 @@
<li><b>Prénom :</b> {{user.prenom_role}}</li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Voir si ce n'est pas plus pertinent d'avoir un champ organisme basé sur bib_organisme + champ texte autre organisme

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pour l'instant on reste sur un champs texte dans le formulaire de création de compte.
Mais oui, ça serait bien à terme.

frontend/src/app/modules/login/sign-up/sign-up.component.ts
if (this.config.ACCOUNT_MANAGEMENT.ACCOUNT_FORM.length > 0) {
finalForm['champs_addi'] = this.dynamicFormGroup.value;
}
// ajout de organisme aux champs addi
finalForm['champs_addi']['organisme'] = this.form.value['organisme'];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enlever organisme des champs prédéfinis et le mettre dans les champs additionnels

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Les champs additionels sont optionnels et à définir dans la config

c'est pas mal au final de garder ce champs dans les champs prédéfinis

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oui on peut se demander si au final on n'en fait pas juste un champs additionnel optionnel et que chacun se le met ou pas...
Mais c'est vrai aussi que c'est un champs classique qui est pertinent dans toute demande de création de compte, à priori.
Donc ça me va de le laisser de base.

@camillemonchicourt camillemonchicourt added this to the 2.13 milestone Jun 12, 2023
@TheoLechemia TheoLechemia merged commit d0ea319 into develop Jun 22, 2023
@TheoLechemia TheoLechemia deleted the feat/register branch June 22, 2023 15:33
jpm-cbna pushed a commit that referenced this pull request Apr 24, 2024
@joelclems @jpm-cbna
fix(sign-up): register organism, display error messages
d431ff0 
Squash commits from PR #2575.
See: https://github.com/PnX-SI/GeoNature/pull/2575/commits
Original authors: @joelclems, @TheoLechemia.
@TheoLechemia
Copy link
Member

@jpm-cbna une erreur ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camillemonchicourt camillemonchicourt camillemonchicourt left review comments

@amandine-sahl amandine-sahl amandine-sahl requested changes

@TheoLechemia TheoLechemia TheoLechemia approved these changes

@jpm-cbna jpm-cbna Awaiting requested review from jpm-cbna

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.13
Development

Successfully merging this pull request may close these issues.
4 participants
@joelclems @TheoLechemia @amandine-sahl @camillemonchicourt