Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(filters): add where on id_role for has_pin #2508

Merged
merged 1 commit into from
May 3, 2023

Conversation

mvergez
Copy link
Contributor

@mvergez mvergez commented Apr 20, 2023

Fixes #2507

@bouttier bouttier added this to the 2.12 milestone Apr 20, 2023
@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (5e25a8c) 69.08% compared to head (34a0d3a) 69.08%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2508   +/-   ##
========================================
  Coverage    69.08%   69.08%           
========================================
  Files           82       82           
  Lines         7138     7138           
========================================
  Hits          4931     4931           
  Misses        2207     2207           
Flag Coverage Δ
pytest 69.08% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nature/core/gn_synthese/utils/query_select_sqla.py 74.40% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mvergez mvergez requested a review from bouttier May 2, 2023 08:09
@bouttier bouttier force-pushed the fix/id-role-filter-pin branch from 34a0d3a to e3673a4 Compare May 3, 2023 16:51
@bouttier bouttier merged commit e3673a4 into PnX-SI:develop May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants