Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for default notification rules #2267

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Conversation

bouttier
Copy link
Contributor

Rules with NULL id_role are used if there are no rules for current user.

@bouttier bouttier force-pushed the feat/default-notifications branch from 14a30ff to 023d6e4 Compare January 13, 2023 19:17
@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Base: 67.83% // Head: 67.83% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (023d6e4) compared to base (60ae414).
Patch coverage: 96.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2267   +/-   ##
========================================
  Coverage    67.83%   67.83%           
========================================
  Files           84       84           
  Lines         7369     7366    -3     
========================================
- Hits          4999     4997    -2     
+ Misses        2370     2369    -1     
Flag Coverage Δ
pytest 67.83% <96.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
backend/geonature/core/notifications/routes.py 97.40% <91.66%> (+0.69%) ⬆️
backend/geonature/core/notifications/models.py 88.60% <100.00%> (+1.65%) ⬆️
backend/geonature/core/notifications/utils.py 90.69% <100.00%> (+0.22%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Rules with NULL id_role are used if there are no rules for current user.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant