Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mustUseCollateralUtxos balancer constraint #1513

Merged
merged 14 commits into from
Dec 10, 2023

Conversation

klntsky
Copy link
Member

@klntsky klntsky commented Jun 20, 2023

Pre-review checklist

  • All code has been formatted using our config (make format)
  • Any new API features or modification of existing behavior is covered as defined in our test plan
  • The changelog has been updated under the ## Unreleased header, using the appropriate sub-headings (### Added, ### Removed, ### Fixed), and the links to the appropriate issues/PRs have been included

Copy link
Contributor

@KristianBalaj KristianBalaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

let
isSpendable = not <<< flip Set.member nonSpendableSet
collateral <- case mbCollateralUtxos of
-- if no collateral utxos are specified, use the wallet
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just update the comment here that it also filters out unspendable ones.

@KristianBalaj
Copy link
Contributor

KristianBalaj commented Jul 7, 2023

@klntsky this works for us, maybe we can merge?

@klntsky
Copy link
Member Author

klntsky commented Jul 25, 2023

@KristianBalaj I just wanted to add some tests. Finally I can work on this again

examples/BalanceTxConstraints.purs Outdated Show resolved Hide resolved
examples/BalanceTxConstraints.purs Show resolved Hide resolved
src/Internal/BalanceTx/Constraints.purs Outdated Show resolved Hide resolved
src/Internal/BalanceTx/BalanceTx.purs Outdated Show resolved Hide resolved
src/Internal/BalanceTx/BalanceTx.purs Outdated Show resolved Hide resolved
src/Internal/BalanceTx/BalanceTx.purs Show resolved Hide resolved
@klntsky klntsky merged commit aad4b64 into develop Dec 10, 2023
3 checks passed
@klntsky klntsky deleted the klntsky/use-additional-addresses-as-collateral branch December 10, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants