Rearrange PythonRunner.Action logger creation. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit bddbfb2c6f38fd97d688eed52f3c9add0cafc623)
vcabbage
added a commit
that referenced
this pull request
Feb 2, 2016
Rearrange PythonRunner.Action logger creation.
|
I just noticed this broke pack tests since logger is no longer initialized inside the constructor - https://travis-ci.org/StackStorm/st2contrib/jobs/110061909#L388 :/ Any particular reason why this change was made? And any objections to moving this setup back to the constructor? |
|
Please ignore my comment above. I thought this is a upstream StackStorm/st2 repo and not a fork :) Lets continue the discussion here - StackStorm@f7b0c38#commitcomment-16169978 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit bddbfb2c6f38fd97d688eed52f3c9add0cafc623)