Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Backup of Uploads with unintended dependency #150

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

Michael-Burke
Copy link
Contributor

@Michael-Burke Michael-Burke commented Jul 20, 2024

Changes

  • Added --no-deps to the backing up of the uploads container
  • This is for a niche use-case where a docker-compose change is staged, but not implemented through a docker command. This will prevent a plextrac backup command to recreate any of the needful dependencies for a backup and fail instead.

Testing

  • OS Tests [Ubuntu, Rocky Linux, RHEL 8/9]
  • Upload backup integrity after change [Comparison and evaluation of date integrity]
  • State variations [app version, app state]

@Michael-Burke Michael-Burke self-assigned this Jul 20, 2024
Copy link
Contributor

@mmorgan-pt mmorgan-pt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Michael-Burke Michael-Burke merged commit d952631 into main Aug 12, 2024
@Michael-Burke Michael-Burke deleted the mdb/bugfix-backup-uploads-no-deps branch August 12, 2024 16:38
Erasmus-Black added a commit to Erasmus-Black/plextrac-manager-util that referenced this pull request Jan 9, 2025
* Bugfix: Install with RTC Failing (PlexTrac#139)

* Reworked mod_start to separate migration call

* Updated RTC env vars for migration in podman

* Reworked timer, podman sections, and reordered install for both

* Bunch of podman related changes to get it to work with RTC

* Added method to auth to CKE Registry specifically

* Fixed minor issue with permissions on backups

* Updated documentation

* Version bump

* var fix

* Removed need for hard-coded plextrac username

* Updated a chown

* Add override for group creation

* Correct position of flag -f

* Bugfix: `PLEXTRAC_HOME` and Migration Container Names (PlexTrac#142)

* Fixed containner naming on pulling logs

* Bump version to 0.7.1

* Bugfix: Messaging Clarity (PlexTrac#146)

* Bad wording in plextrac stop command

* Updated migration container message to be more clear

* Missing space

* Bugfix: Removal of deprecated SMTP values (PlexTrac#145)

* Removal of deprecated env values

* Version bump

* Bugfix: Check for migration container (PlexTrac#143)

* Added actual container check

* added podman support

* Updated to validate against podman / docker correctly

* missed a docker call

* add a mac file for examples on running this on apple silicon (PlexTrac#112)

Co-authored-by: Michael Burke <72173919+Michael-Burke@users.noreply.github.com>

* sp\ Adds MinIO ENV Support For Future State

* sp\ENV Var Fix For MinIO

* Version bump

* Updated method to be variable for future use

* OPS-350: PGVector Enable (PlexTrac#144)

* OPS-350: PGVector Enable

* OPS-350: condition execution pg:superuser:bootstrap on script existence

* Updated docker-compose.yml to add the new plextrac postgres image

* Corrected new postgres image name

* Reflecting the image change for Podman users

* Version bump

---------

Co-authored-by: Michael Burke <michael@plextrac.com>
Co-authored-by: Michael Burke <72173919+Michael-Burke@users.noreply.github.com>

* Bugfix: Suppress warning on normal updates (PlexTrac#149)

* Fixed error message showing up on utility update when SKIP_SELF_UPGRADE wasn't set

* Version bump to v0.7.5

* Bugfix: Backup of Uploads with unintended dependency (PlexTrac#150)

Added --no-deps to the backing up of the uploads container

* version bump to 0.7.6

* Bugfix: Migration logs, `plextrac info` postgres bug, better messaging (PlexTrac#152)

* Fixed warning about missing postgres container due to hardcoded image name

* Fixed printf usage on migration container log printing to console and exiting script

* Fixed messaging around starting update so it doesn't look like it freezes after acknowledging warning

* Updated some Podman documentation

* Iterated version to 0.7.7

* sp\logix for 2.10 Contiguous Updates

* Change var name in if logic

* Bump version to 0.7.8

* Update src/_update.sh

Co-authored-by: mmorgan-pt <99763568+mmorgan-pt@users.noreply.github.com>

* sp\Minio Object Sotrage Service Declaration

* Forgot to add a few other vars

* Push version updates

* Mm/semver bugfix (PlexTrac#155)

* This seems to be working

* some tweaks for more testing

* cleanup of comments and another sort for the latest tag

---------

Co-authored-by: ali <amyahya@gmail.com>

* feat: add new env vars relating to cteam-56

* docs: update comment

* fix: update ctem api url value and add it to notification services

* fix: fix whitespace in docker compose

* fix: another whitespace fix

* sp\bump version

* Ensure correct uploads volume ownership

* podman postgres tweaks

* Changes Podman PG startup image

* missed one

* 2.11 Bump Version

* Update airgapped.md

* remove duplicate podman pulls

* bumped version

* add podman remove for containers

* close if statement

* add entrypoint override for migrations container

* put the entrypoint into the entrypoint line rather than array

* sp\minio-image-update

* minio service definiions updated

* Mm/stop and start tweak (PlexTrac#169)

* add checks for the stop process

* function, not variable

* docker not compose

* bumpversion and update more comments

---------

Co-authored-by: Michael Burke <72173919+Michael-Burke@users.noreply.github.com>
Co-authored-by: mmorgan-pt <99763568+mmorgan-pt@users.noreply.github.com>
Co-authored-by: Steven Paugh <spaugh@plextrac.com>
Co-authored-by: Steven Paugh <122935851+StevenPaugh@users.noreply.github.com>
Co-authored-by: Michael Burke <michael@plextrac.com>
Co-authored-by: JJ Zabkar <148792556+jjzabkar-plextrac@users.noreply.github.com>
Co-authored-by: ali <amyahya@gmail.com>
Co-authored-by: Nate Pratt <npratt@plextrac.com>
Co-authored-by: Darius Houle <126509519+darius-plextrac@users.noreply.github.com>
Co-authored-by: Tim Daly <155962442+EramusBlack1@users.noreply.github.com>
Co-authored-by: Mike Morgan <mmorgan@plextrac.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants