Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: RHEL 7 Compatibility #108

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Bugfix: RHEL 7 Compatibility #108

merged 2 commits into from
Feb 16, 2024

Conversation

Michael-Burke
Copy link
Contributor

@Michael-Burke Michael-Burke commented Feb 1, 2024 •
edited
Loading

#Bugfix: RHEL 7

Found that the RHEL bash and diff packages are older and incompatible with some ways commands are written for Bash 5+

Tasks

  • Updated OS Check to validate for RHEL 7 and remove command non-existent in older packages
    • Specifically around the diff command and the --nobest flag for yum
  • Updated array usage in the _version_check.sh to be bash version 4 friendly for RHEL 7 users

Testing

  • RHEL7 -- FUNCTIONAL
  • Ubuntu -- FUNCTIONAL
  • * -- FUNCTIONAL

@Michael-Burke Michael-Burke self-assigned this Feb 1, 2024
mmorgan-pt
mmorgan-pt approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@mmorgan-pt mmorgan-pt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Nice work!

@Michael-Burke Michael-Burke merged commit d9cd53c into main Feb 16, 2024
@Michael-Burke Michael-Burke deleted the mdb/fix-to-support-rhel7 branch February 16, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmorgan-pt mmorgan-pt mmorgan-pt approved these changes

Assignees

@Michael-Burke Michael-Burke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Michael-Burke @mmorgan-pt