-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sidecar to Daemonset #97
Conversation
0f71003
to
b6caa5f
Compare
b6caa5f
to
5e29bb4
Compare
5e29bb4
to
854cfcf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nits, but nothing blocking related to this change. Glad to see this getting merged in!
- gameserverdetails | ||
verbs: | ||
- get | ||
apiVersion: rbac.authorization.k8s.io/v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I like the comment at the top of the old file describing what the intent is
f1e6331
to
149a186
Compare
149a186
to
e785384
Compare
2585a6c
to
29ad20d
Compare
29ad20d
to
26f544d
Compare
PR to remove the sidecar in favor of a DaemonSet. Fixes #107. TODO items:
patch
instead ofupdate