-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't exit with error when running help #35
Conversation
Changed exit status to success when running help to help with interoperability with direnv
What do you mean? Seems to work fine for me on haskell-template: |
@srid Thanks for looking at this and bearing with me. While documenting this I nailed down the exact reason our experiences are different. It comes down to the following setting Looking at
With the option becoming default "in the future" I hope that is enough motivation and clarity to accept this PR with or without modifications. Either way thanks for listening 😄 Somewhat irrelevant documentationI thought I figured this out last night but maybe not. Just to tie these two different reports together for another 3rd party I also explored the same issue I'm experiencing here srid/rust-nix-template#21. Doing the same thing you did above produces the following result: I validated that when direnv gave the following error I acknowledge it's working for your setup. There must be something with my environment that is different. I'll try to reduce my environment to see if that gets me some more information. I'm documenting what I have learned thus far here.
Apologies if this is noise. Just trying to get this neat tool working for me correctly 😄 . It seems like my shell or direnv is being more strict with the error or something. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, great. That's good to know. strict_env
should indeed be enabled, IMO. Thanks for the info.
This comment was marked as outdated.
This comment was marked as outdated.
I think you might be behind origin or something. The I just built HEAD of the repo and it worked... with no default menu displaying. I haven't used |
Maybe need a |
Hmm, yea, false alarm. |
Changed exit status to success when running help to allow interoperability with direnv
When using direnv mission-control's help would run when moving into the directory. Help would exit with an error and thus direnv would this something went wrong when loading into the environment and back out. This caused direnv to be effectively useless when used in combination with mission-control.