Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add private file #513

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

givetimetolife
Copy link

add private file

@mig42
Copy link
Contributor

mig42 commented Nov 4, 2024

Hi, the command implementation looks good at a first glance, though there are a few linting issues to fix. We'd need some tests to ensure that it doesn't break in the future, too.

Additionally, the proposal is to add the Add command to all items in the changes list. That should only apply to private items, as is the intention of the PR and the expected usage of the command. The problem is, the status refresh only returns items under version control currently, because we didn't have the add functionality. So we'd have to sort that before moving forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants