Should throw error after catching it

[Pjaijai]

No description provided.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
referalah	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 13, 2023 8:29pm

[tommyttf]

It you throw it eventually without any handling in the catch block, then no need to catch it at the first place

[Pjaijai]

@tommyttf We do have some error handling in api hooks. If we don't throw error, the hooks will not run onError.

[tommyttf]

I mean

  createPost: async (req: ICreatePostRequest) => {
    try {
      await supabase.from("post").insert({
        url: req.url,
        country_uuid: req.countryUuid,
        province_uuid: req.provinceUuid,
        city_uuid: req.cityUuid,
        industry_uuid: req.industryUuid,
        year_of_experience: req.yearOfExperience,
        created_by: req.createdBy,
        type: req.type,
        company_name: req.companyName.trim(),
        job_title: req.jobTitle.trim(),
        description: req.description.trim(),
      })
    } catch (error) {
      throw error
    }
  },

is the same as

createPost: async (req: ICreatePostRequest) => {
    await supabase.from("post").insert({
      url: req.url,
      country_uuid: req.countryUuid,
      province_uuid: req.provinceUuid,
      city_uuid: req.cityUuid,
      industry_uuid: req.industryUuid,
      year_of_experience: req.yearOfExperience,
      created_by: req.createdBy,
      type: req.type,
      company_name: req.companyName.trim(),
      job_title: req.jobTitle.trim(),
      description: req.description.trim(),
    })
},

so no need to catch it here, just let it throw out to the onError handling

[Pjaijai]

Right will do some refactoring later.