Fixed brightness tool symmetry and added multi-layer magic wand support #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
flabbet
commented
Apr 8, 2023
•
flabbet
commented
- The brightness tool behaves weirdly when combined with symmetry #440 Addd pixel processor func to PixelOperation which acts a little like a post-process for pixels, so PixelOperation can be a little more dynamic. This fixes the issue with brightness tool symmetry
- Can't use Magic Wand on all layers when a folder is selected #477
flabbet
changed the title
Equbuxu
requested changes
Apr 8, 2023
| { | ||
| path.MoveTo(point); | ||
| this.mode = mode; | ||
| this.memberGuid = memberGuid; | ||
| this.referenceAll = referenceAll; | ||
| this.memberGuids = memberGuids; | ||
| this.drawOnMask = drawOnMask; |
There was a problem hiding this comment.
I've just noticed that drawOnMask is completely unused, let's remove it
| var pos = controller!.LastPixelPosition; | ||
|
|
||
| internals!.ActionAccumulator.AddActions(new MagicWand_Action(memberGuid, pos, mode, considerAllLayers, drawOnMask)); | ||
| internals!.ActionAccumulator.AddActions(new MagicWand_Action(memberGuids, pos, mode, considerAllLayers)); |
There was a problem hiding this comment.
you are passing considerAllLayers as the drawOnMask argument (which is completely unused so this isn't a bug, it's just weird)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.